New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: does not check for IO errors on every transaction #6091

Merged
2 commits merged into from Oct 20, 2015

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented Sep 27, 2015

mon/MonitorDBStore: assert/crash if there is a write error
Do this globally intead of relying on teh zillion mon callers to
check the error code.  There are no cases where we want to
tolerate a commit failure.

Fixes: #13089
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 2fb7b1f)

@smithfarm smithfarm self-assigned this Sep 27, 2015

@smithfarm smithfarm added this to the firefly milestone Sep 27, 2015

mon/Elector: do a trivial write on every election cycle
Currently we already do a small write when the *first* election in
a round happens (to update the election epoch).  If the backend
happens to fail while we are already in the midst of elections,
however, we may continue to call elections without verifying we
are still writeable.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit ef909cc)

    Conflicts:
	src/mon/Elector.cc
            no MonitorDBStore::TransactionRef in firefly

ghost pushed a commit that referenced this pull request Oct 20, 2015

Merge pull request #6091: mon: does not check for IO errors on every …
…transaction

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

ghost commented Oct 20, 2015

@liewegas does this backport look good to merge ? It passed a run of the firefly rados suite ( see http://tracker.ceph.com/issues/11644#note-110 ). Note that there was a valgrind issues but it is unrelated and fixed by #6325.

@liewegas

This comment has been minimized.

Member

liewegas commented Oct 20, 2015

👍

ghost pushed a commit that referenced this pull request Oct 20, 2015

Loic Dachary
Merge pull request #6091 from SUSE/wip-13252-firefly
mon: does not check for IO errors on every transaction

Reviewed-by: Sage Weil <sage@redhat.com>

@ghost ghost merged commit 143e267 into ceph:firefly Oct 20, 2015

@smithfarm smithfarm deleted the SUSE:wip-13252-firefly branch Oct 20, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment