Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/ops: With root as default user, unable to have multiple RGW instances running #6161

Merged
7 commits merged into from Oct 12, 2015

Conversation

Projects
None yet
5 participants

Dmitry Yatsushkevich and others added some commits Mar 17, 2015

rgw: init script waits until the radosgw stops
Fixes: #11140
Init script waits in stop action until the radowgw daemons stop.

Signed-off-by: Dmitry Yatsushkevich <dyatsushkevich@mirantis.com>
(cherry picked from commit 1cca0c1)
init-radosgw: look in /var/lib/ceph/radosgw
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit a4bb992)
doc: rgw: fix typo in comments
Signed-off-by: Nathan Cutler <ncutler@suse.cz>
(cherry picked from commit 05cf0db)
init-radosgw: unify init-radosgw[.sysv]
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 1c45f51)
rgw: fix radosgw start-up script.
radosgw init script is unable to start radosgw daemon.
as it is relies on requiretty being disabled.
once init script start this daemon with sudo it fails
to start the daemon.

changing 'sudo' to 'su', it will fix this issue and
will also help running radosgw daemon with our new
"ceph" UID project.

Fixes: #10927

Signed-off-by: Vikhyat Umrao <vumrao@redhat.com>
(cherry picked from commit c835422)
init-radosgw: specify pid file to start-stop-daemon
This fixes restart when multiple instances are running.

Fixes: #12407
Tested-by: Pavan Rallabhandi <pavan.rallabhandi@sandisk.com>
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit e17c8e1)

@ghost ghost self-assigned this Oct 2, 2015

@ghost ghost added this to the hammer milestone Oct 2, 2015

@ghost ghost added bug fix rgw labels Oct 2, 2015

ghost pushed a commit that referenced this pull request Oct 2, 2015

Merge pull request #6161: With root as default user, unable to have m…
…ultiple RGW instances running

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 3, 2015

Merge pull request #6161: With root as default user, unable to have m…
…ultiple RGW instances running

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 3, 2015

Merge pull request #6161: With root as default user, unable to have m…
…ultiple RGW instances running

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 3, 2015

Merge pull request #6161: With root as default user, unable to have m…
…ultiple RGW instances running

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 7, 2015

Merge pull request #6161: With root as default user, unable to have m…
…ultiple RGW instances running

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 8, 2015

Merge pull request #6161: With root as default user, unable to have m…
…ultiple RGW instances running

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

Copy link
Author

ghost commented Oct 10, 2015

@yehudasa does this backport look good to merge ? It passed a run of the hammer rgw suite ( see http://tracker.ceph.com/issues/13356#note-5 for details ).

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Oct 12, 2015

missing this commit: 9d8c115
otherwise, red hat still uses the .sysv script that doesn't actually get fixed.

@ktdreyer can you take a look?

@ktdreyer

This comment has been minimized.

Copy link
Member

ktdreyer commented Oct 12, 2015

Agreed, 9d8c115 is needed

init-radosgw.sysv: remove
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 9d8c115)
@ghost

This comment has been minimized.

Copy link
Author

ghost commented Oct 12, 2015

in the gitbuilders, will run the ceph-deploy suite on CentOS 6.5 before merging to assert nothing stupid is broken

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Oct 12, 2015

cool lgtm

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Oct 12, 2015

teuthology-suite --machine-type vps --suite ceph-deploy --suite-branch hammer --ceph wip-13227-hammer --filter=centos_6 --email loic@dachary.org

ghost pushed a commit that referenced this pull request Oct 12, 2015

Loic Dachary
Merge pull request #6161 from dachary/wip-13227-hammer
With root as default user, unable to have multiple RGW instances running

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Yehuda Sadeh <ysadehwe@redhat.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

@ghost ghost merged commit 7f485ed into ceph:hammer Oct 12, 2015

@ghost ghost changed the title With root as default user, unable to have multiple RGW instances running build/ops: With root as default user, unable to have multiple RGW instances running Oct 12, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.