New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: GWWatcher::handle_error -> common/Mutex.cc: 95: FAILED assert(r == 0) #6164

Merged
merged 1 commit into from Oct 12, 2015

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Oct 2, 2015

rgw: delete finisher only after finalizing watches
Fixes: #12208

The watch error path might try to schedule a finisher work, delete finisher
only after watch destruction.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
(cherry picked from commit 97aed59)

@ghost ghost self-assigned this Oct 2, 2015

@ghost ghost added this to the hammer milestone Oct 2, 2015

@ghost ghost added bug fix rgw labels Oct 2, 2015

ghost pushed a commit that referenced this pull request Oct 2, 2015

Merge pull request #6164: hammer: GWWatcher::handle_error -> common/M…
…utex.cc: 95: FAILED assert(r == 0)

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost changed the title from hammer: GWWatcher::handle_error -> common/Mutex.cc: 95: FAILED assert(r == 0) to rgw: GWWatcher::handle_error -> common/Mutex.cc: 95: FAILED assert(r == 0) Oct 3, 2015

ghost pushed a commit that referenced this pull request Oct 3, 2015

Merge pull request #6164: rgw: GWWatcher::handle_error -> common/Mute…
…x.cc: 95: FAILED assert(r == 0)

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 3, 2015

Merge pull request #6164: rgw: GWWatcher::handle_error -> common/Mute…
…x.cc: 95: FAILED assert(r == 0)

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 3, 2015

Merge pull request #6164: rgw: GWWatcher::handle_error -> common/Mute…
…x.cc: 95: FAILED assert(r == 0)

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 7, 2015

Merge pull request #6164: rgw: GWWatcher::handle_error -> common/Mute…
…x.cc: 95: FAILED assert(r == 0)

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 8, 2015

Merge pull request #6164: rgw: GWWatcher::handle_error -> common/Mute…
…x.cc: 95: FAILED assert(r == 0)

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

ghost commented Oct 10, 2015

@yehudasa does this backport look good to merge ? It passed a run of the hammer rgw suite ( see http://tracker.ceph.com/issues/13356#note-5 for details ).

yehudasa added a commit that referenced this pull request Oct 12, 2015

Merge pull request #6164 from dachary/wip-13053-hammer
rgw: GWWatcher::handle_error -> common/Mutex.cc: 95: FAILED assert(r == 0)

@yehudasa yehudasa merged commit 8078233 into ceph:hammer Oct 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment