New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: TEST_crush_rule_create_erasure consistently fails on i386 builder #6201

Merged
1 commit merged into from Oct 9, 2015

Conversation

Projects
None yet
4 participants
@ghost

ghost commented Oct 8, 2015

tests: robust test for the pool create crushmap test
The test that goes with f1e86be to
verify that a bugous crush ruleset will prevent the creation of a pool
trying to use it was fragile. I depends on the implementation of the
erasure code lrc plugin and turns out to not work on i386.

The test is modified to use a fake crushtool that always returns false
and validate that it prevents the creation of a pool, which demonstrate
it is used for crushmap validation prior to the pool creation.

http://tracker.ceph.com/issues/12419 Fixes: #12419

Signed-off-by: Loic Dachary <ldachary@redhat.com>
(cherry picked from commit e479037)

@ghost ghost self-assigned this Oct 8, 2015

@ghost ghost added this to the hammer milestone Oct 8, 2015

@ghost ghost added bug fix core labels Oct 8, 2015

@ghost ghost assigned liewegas and unassigned ghost Oct 8, 2015

@ghost

This comment has been minimized.

ghost commented Oct 8, 2015

I did not notice the test failed on i386 in hammer, this fixes it.

@ghost

This comment has been minimized.

ghost commented Oct 8, 2015

verifying in the gitbuilders

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Oct 9, 2015

ghost pushed a commit that referenced this pull request Oct 9, 2015

Loic Dachary
Merge pull request #6201 from dachary/wip-13410-hammer
TEST_crush_rule_create_erasure consistently fails on i386 builder

Reviewed-by: Kefu Chai <kchai@redhat.com>

@ghost ghost merged commit 036c718 into ceph:hammer Oct 9, 2015

@ghost ghost changed the title from TEST_crush_rule_create_erasure consistently fails on i386 builder to tests: TEST_crush_rule_create_erasure consistently fails on i386 builder Oct 12, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment