New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/ops: Fix -Wno-format and -Werror=format-security options clash #6207

Merged
1 commit merged into from Oct 20, 2015

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented Oct 8, 2015

Fix -Wno-format and -Werror=format-security options clash
This causes build failure in latest fedora builds, ceph_test_librbd_fsx adds -Wno-format cflag but the default AM_CFLAGS already contain -Werror=format-security, in previous releases, this was tolerated but in the latest fedora rawhide it no longer is, ceph_test_librbd_fsx builds fine without -Wno-format on x86_64 so there is likely no need for the flag anymore

Signed-off-by: Boris Ranto <branto@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 7df67a5)

Conflicts:
	src/test/Makefile.am

@smithfarm smithfarm self-assigned this Oct 8, 2015

@smithfarm smithfarm added this to the firefly milestone Oct 8, 2015

@smithfarm smithfarm added bug fix core build/ops and removed core labels Oct 8, 2015

ghost pushed a commit that referenced this pull request Oct 20, 2015

Merge pull request #6207: Fix -Wno-format and -Werror=format-security…
… options clash

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 20, 2015

Loic Dachary
Merge pull request #6207 from SUSE/wip-13417-firefly
Fix -Wno-format and -Werror=format-security options clash 

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit 14c8528 into ceph:firefly Oct 20, 2015

@smithfarm smithfarm deleted the SUSE:wip-13417-firefly branch Oct 20, 2015

@ghost ghost changed the title from Fix -Wno-format and -Werror=format-security options clash to build/ops: Fix -Wno-format and -Werror=format-security options clash Oct 24, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment