Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert: __STRING macro is not defined by musl libc. #6210

Merged
merged 1 commit into from Oct 24, 2015

Conversation

Projects
None yet
4 participants
@dx9
Copy link
Contributor

dx9 commented Oct 9, 2015

Signed-off-by: John Coyle dx9err@gmail.com

@tchaikov tchaikov added the build/ops label Oct 9, 2015

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Oct 9, 2015

@dx9 the change looks great, but before we merge it, could you also add the signed-off-by line at the end of your commit message? and it would be ideal if you can also prefix your commit message with "assert: ". you can see more examples using

git log src/include/assert.h

@tchaikov tchaikov self-assigned this Oct 9, 2015

@dx9 dx9 force-pushed the dx9:wip-12406-alpine-string-macro branch from fe8517c to ee2ffbc Oct 9, 2015

@dx9

This comment has been minimized.

Copy link
Contributor Author

dx9 commented Oct 9, 2015

@tchaikov for sure

@dx9 dx9 changed the title alpine: __STRING macro is not defined by musl libc. assert: __STRING macro is not defined by musl libc. Oct 10, 2015

@liewegas liewegas added the needs-qa label Oct 18, 2015

assert: __STRING is not defined by musl libc. Define __STRING when it…
… is missing.

Signed-off-by: John Coyle <dx9err@gmail.com>

@dx9 dx9 force-pushed the dx9:wip-12406-alpine-string-macro branch from ee2ffbc to 4f7bcab Oct 18, 2015

liewegas added a commit that referenced this pull request Oct 24, 2015

Merge pull request #6210 from dx9/wip-12406-alpine-string-macro
assert: __STRING macro is not defined by musl libc.

Reviewed-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit 69ace85 into ceph:master Oct 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.