Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: add a field indicate xattr only one chunk for set xattr. #6244

Merged
merged 1 commit into from Oct 25, 2015

Conversation

Projects
None yet
3 participants
@majianpeng
Copy link
Member

majianpeng commented Oct 13, 2015

Because the limit of osd backend, we split xattr into a lot of small
pieces. When set xatt, it should remove the old pieces.
But for some xattr especially for inline xattr, we know it only
one chunk. So it can skip this remove operation.

Signed-off-by: Jianpeng Ma jianpeng.ma@intel.com

os: add a field indicate xattr only one chunk for set xattr.
Because the limit of osd backend, we split xattr into a lot of small
pieces. When set xatt, it should remove the old pieces.
But for some xattr especially for inline xattr, we know it only
one chunk. So it can skip this remove operation.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Oct 14, 2015

Should we just be using sys_setxattr directly here? No reason we need the chain wrapper, right?

@majianpeng

This comment has been minimized.

Copy link
Member Author

majianpeng commented Oct 15, 2015

No, because in chain_setxattr, we call get_raw_xattr_name. So i think my method maybe better.

@liewegas liewegas added the needs-qa label Oct 15, 2015

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Oct 15, 2015

Ah I see, makes sense!

liewegas added a commit that referenced this pull request Oct 25, 2015

Merge pull request #6244 from majianpeng/filestore-xattr
os/FileStore: avoid removexattr call on chain_setxattr when value is known to be small

Reviewed-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit 8eafeec into ceph:master Oct 25, 2015

@majianpeng majianpeng deleted the majianpeng:filestore-xattr branch Nov 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.