Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: drop the interim set from load_pgs() #6277

Merged
merged 1 commit into from Oct 24, 2015

Conversation

Projects
None yet
3 participants
@branch-predictor
Copy link
Member

branch-predictor commented Oct 15, 2015

During execution of load_pgs(), all PGs are added to interim set and then
processed again from the beginning. Discard this extra loop and entire
interim set, saving a bit of memory and CPU time (by better utilization
of L1/L2 caches).

Signed-off-by: Piotr Dałek piotr.dalek@ts.fujitsu.com

osd: drop the interim set from load_pgs()
During execution of load_pgs(), all PGs are added to interim set and then
processed again from the beginning. Discard this extra loop and entire
interim set, saving a bit of memory and CPU time (by better utilization
of L1/L2 caches).

Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>

@ghost ghost added cleanup core labels Oct 16, 2015

@liewegas liewegas added the needs-qa label Oct 19, 2015

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Oct 19, 2015

Reviewed-by:

liewegas added a commit that referenced this pull request Oct 24, 2015

Merge pull request #6277 from branch-predictor/bp-pgload-rm-interim-set
osd: drop the interim set from load_pgs()

Reviewed-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit 5c4bfea into ceph:master Oct 24, 2015

@branch-predictor branch-predictor deleted the branch-predictor:bp-pgload-rm-interim-set branch Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.