Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcephfs: only check file offset on glibc platforms #6288

Merged
merged 1 commit into from Oct 19, 2015

Conversation

Projects
None yet
4 participants
@dx9
Copy link
Contributor

dx9 commented Oct 15, 2015

File offset on Alpine is also 64-bit, but does not define a OS macro.

libcephfs: only check file offset on glibc platforms
Signed-off-by: John Coyle dx9err@gmail.com
@jcsp

This comment has been minimized.

Copy link
Contributor

jcsp commented Oct 16, 2015

This looks pretty sane to me, but I wasn't around when these original checks were added, @liewegas ?

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Oct 16, 2015

looks right to me. I also don't remember this clearly at all...

@jcsp

This comment has been minimized.

Copy link
Contributor

jcsp commented Oct 16, 2015

I've pushed this branch to the ceph repo so that we can check there aren't any gitbuilder whoopsies before merging

@jcsp jcsp self-assigned this Oct 16, 2015

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Oct 19, 2015

gitbuilder looks happy

liewegas added a commit that referenced this pull request Oct 19, 2015

Merge pull request #6288 from dx9/wip-12406-file-offset-check
libcephfs: only check file offset on glibc platforms

Reviewed-by: John Spray <john.spray@redhat.com>

@liewegas liewegas merged commit dc4a69b into ceph:master Oct 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.