Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip zafman ceph #6329

Merged
merged 4 commits into from Oct 31, 2015

Conversation

Projects
None yet
3 participants
@dzafman
Copy link
Member

dzafman commented Oct 21, 2015

Minor fixes to ceph command:

dzafman added some commits Oct 21, 2015

makefile: For ceph command generation don't append another copy of ce…
…ph.in

Signed-off-by: David Zafman <dzafman@redhat.com>
ceph.in: Don't drop out of command mode on certain kinds of errors
Signed-off-by: David Zafman <dzafman@redhat.com>
ceph.in: Remove unused variable
Signed-off-by: David Zafman <dzafman@redhat.com>
ceph.in: Notify user that 'tell' can't be used in interactive mode
Signed-off-by: David Zafman <dzafman@redhat.com>

@dzafman dzafman force-pushed the dzafman:wip-zafman-ceph branch from b515f12 to a341d97 Oct 30, 2015

@dzafman dzafman changed the title DNM: Wip zafman ceph Wip zafman ceph Oct 30, 2015

@dzafman

This comment has been minimized.

Copy link
Member Author

dzafman commented Oct 30, 2015

Without my change this is the broken behavior:

$ ceph
ceph> tell osd.0 bench 1024 4096
Error: 22 EINVAL
Status:
unrecognized command! [{"prefix": "tell", "args": ["bench", "1024", "4096"]}]

@dmick

This comment has been minimized.

Copy link
Member

dmick commented Oct 31, 2015

LGTM.

dmick added a commit that referenced this pull request Oct 31, 2015

Merge pull request #6329 from dzafman/wip-zafman-ceph
Wip zafman ceph

Reviewed-by: Dan Mick <dmick@redhat.com>

@dmick dmick merged commit 2d56728 into ceph:master Oct 31, 2015

@dzafman dzafman deleted the dzafman:wip-zafman-ceph branch Oct 31, 2015

@ghost ghost added the build/ops label Feb 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.