Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rados write benchmark new options #6340

Merged
3 commits merged into from Nov 4, 2015

Conversation

Projects
None yet
2 participants
@joaquimrocha
Copy link
Contributor

joaquimrocha commented Oct 21, 2015

These changes add three new options to "rados bench write", in order to control where the contents will be written: in the object, in the omap, has xattributes.
The new options to control that are, respectively, --write-object, --write-omap, --write-xattr .

When used alone or combined, the benchmark will write only in the respective destinations. When none is used, it works as before, writing only to the object.

This is useful to test how fast or slow writing to different destinations is. I hope you consider it as a good addition to the current command.

Cheers,

@ghost ghost added feature tests labels Oct 28, 2015

@ghost

This comment has been minimized.

Copy link

ghost commented Oct 28, 2015

@joaquimrocha could you please add test cases in src/test/test_rados_tool.sh to cover this ?

@ghost ghost self-assigned this Oct 28, 2015

@ghost

This comment has been minimized.

Copy link

ghost commented Oct 28, 2015

Great feature :-)

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

Copy link

ghost commented Oct 28, 2015

Once the test have been added, they can be run with:

teuthology-openstack --verbose --key-name myself  --key-filename ~/Downloads/myself --suite rados/singleton/all/radostool.yaml --suite-branch master --ceph rados_write_benchmark_new_options --ceph-git-url https://github.com/joaquimrocha/ceph.git

joaquimrocha added some commits Oct 19, 2015

tools/rados/rados.cc: Write to different destinations
The write benchmark only writes the objects' contents, not the omap
nor the extended attributes, which is something also interesting to
measure depending on the cluster's configuration.

These changes add a way to specify where the contents should be
written, allowing to combine any of the destinations mentioned above.

Signed-off-by: Joaquim Rocha <joaquim.rocha@cern.ch>
tools/rados/rados.cc: Add options to choose the benchmark's write des…
…tination

Signed-off-by: Joaquim Rocha <joaquim.rocha@cern.ch>
test/test_rados_tool.sh: Add tests for the new bench's write options
Those are the combinations of --write-omap, --write-xattr and --write-object.

Signed-off-by: Joaquim Rocha <joaquim.rocha@cern.ch>

@joaquimrocha joaquimrocha force-pushed the joaquimrocha:rados_write_benchmark_new_options branch from ebc84be to da6825d Nov 4, 2015

@joaquimrocha

This comment has been minimized.

Copy link
Contributor Author

joaquimrocha commented Nov 4, 2015

Hi @dachary , I have added the tests as you requested. Hope this can be merged soon :)
Kind regards,

@ghost

This comment has been minimized.

Copy link

ghost commented Nov 4, 2015

@joaquimrocha if you have access to an OpenStack cluster, you can run

teuthology-openstack --verbose --key-name myself  --key-filename ~/Downloads/myself --suite rados/singleton/all/radostool.yaml --suite-branch master --ceph rados_write_benchmark_new_options --ceph-git-url https://github.com/joaquimrocha/ceph.git

by yourself.

@ghost

This comment has been minimized.

Copy link

ghost commented Nov 4, 2015

Hum, unfortunately the integration test runs a test file by the same name but in a different location. Trying manually.

@ghost

This comment has been minimized.

Copy link

ghost commented Nov 4, 2015

manually tested

@ghost ghost added the tools label Nov 4, 2015

ghost pushed a commit that referenced this pull request Nov 4, 2015

Loic Dachary
Merge pull request #6340 from joaquimrocha/rados_write_benchmark_new_…
…options

Rados write benchmark new options

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit e2a5ebb into ceph:master Nov 4, 2015

@joaquimrocha

This comment has been minimized.

Copy link
Contributor Author

joaquimrocha commented Nov 4, 2015

Great! Thanks!

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.