Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Use uname instead of arch. #6358

Merged
merged 1 commit into from Oct 29, 2015

Conversation

Projects
None yet
4 participants
@dx9
Copy link
Contributor

dx9 commented Oct 22, 2015

No description provided.

cmake: Use uname instead of arch. arch is deprecated in linux-utils a…
…nd coreutils does not install it by default.

Signed-off-by: John Coyle <dx9err@gmail.com>
@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Oct 29, 2015

citation needed:

arch is deprecated in linux-utils
https://git.kernel.org/cgit/utils/util-linux/util-linux.git/commit/?id=27abd8094845b4b2002a8ed5c3dd212999902c8f

and coreutils does not install it by default.

quote from http://www.gnu.org/software/coreutils/manual/html_node/arch-invocation.html#arch-invocation

arch is not installed by default, so portable scripts should not rely on its existence.

tchaikov added a commit that referenced this pull request Oct 29, 2015

Merge pull request #6358 from dx9/wip-12406-cmake-arch-detection
cmake: Use uname instead of arch.

Reviewed-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov merged commit f9fdf47 into ceph:master Oct 29, 2015

@tchaikov tchaikov self-assigned this Oct 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.