Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyValueStore: fix the name's typo of keyvaluestore_default_strip_size #6375

Merged
merged 1 commit into from Oct 26, 2015

Conversation

Projects
None yet
3 participants
@david-z
Copy link
Member

david-z commented Oct 26, 2015

This should be a name's typo of keyvaluestore_default_strip_size, which causes the dynamically changing of this option doesn't work.

Signed-off-by: Zhi Zhang zhangz.david@outlook.com

@ghost ghost added bug fix core labels Oct 26, 2015

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Oct 26, 2015

@david-z could you add Signed-off-by: Zhi Zhang <zhangz.david@outlook.com> at the end of your commit message? you added it in the pull request, but you also need to add it to the commit also, see https://github.com/ceph/ceph/blob/master/SubmittingPatches#L62 . and the patch would be lgtm with the signed-off line. thanks.

KeyValueStore: fix the name's typo of keyvaluestore_default_strip_size
Signed-off-by: Zhi Zhang <zhangz.david@outlook.com>

@david-z david-z force-pushed the david-z:wip-fix-kv-stripe-size-conf branch from 4046db1 to 56d6929 Oct 26, 2015

@david-z

This comment has been minimized.

Copy link
Member Author

david-z commented Oct 26, 2015

@tchaikov Thanks, just forget to add such line. Please review it again.

tchaikov added a commit that referenced this pull request Oct 26, 2015

Merge pull request #6375 from david-z/wip-fix-kv-stripe-size-conf
KeyValueStore: fix the name's typo of keyvaluestore_default_strip_size

Reviewed-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov merged commit 21a0e1b into ceph:master Oct 26, 2015

@tchaikov tchaikov self-assigned this Oct 26, 2015

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Oct 26, 2015

since "keyvaluestore" is still experimental, we might not need to backport it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.