Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocksdb: remove rdb source files from dist tarball #6379

Merged
1 commit merged into from Oct 27, 2015

Conversation

Projects
None yet
2 participants
@tchaikov
Copy link
Contributor

tchaikov commented Oct 26, 2015

rdb is based on NodeJS, and we don't build rdb to use rocksdb as
a keyvaluestore backend.

Fixes: #13554
Signed-off-by: Kefu Chai kchai@redhat.com

rocksdb: remove rdb source files from dist tarball
rdb is based on NodeJS, and we don't build rdb to use rocksdb as
a keyvaluestore backend.

Fixes: #13554
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov added the build/ops label Oct 26, 2015

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

tchaikov commented Oct 26, 2015

@dachary could you help review this patch? i created a dist tarball with this change using

$ ./configure
$ make dist

, and the tarball compiled successfully using

$ ./configure --with-librocksdb-static --without-lttng
$ make -j8
@ghost

This comment has been minimized.

Copy link

ghost commented Oct 26, 2015

I'm not sure this will fix the problem. It shows once in a while and I have no clue why... I can't browse the web right now so it's difficult to investigate :-) I ran make dist a few times locally and it did not show. Since make dist is not run in parallel, I don't see how it could have this error just once in a while ?

@ghost ghost self-assigned this Oct 26, 2015

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

tchaikov commented Oct 27, 2015

not sure why the "make dist" tried to compile the rdb source files. but by (blindly) removing them, i guess we are safer now? as the Makefile won't be aware of the existence of these source files at all.

ghost pushed a commit that referenced this pull request Oct 27, 2015

Loic Dachary
Merge pull request #6379 from tchaikov/wip-13554
rocksdb: remove rdb source files from dist tarball

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit 26dbcd6 into ceph:master Oct 27, 2015

@tchaikov tchaikov deleted the tchaikov:wip-13554 branch Jun 13, 2016

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.