Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: port uniqueness reminder #6387

Merged
1 commit merged into from Oct 27, 2015

Conversation

Projects
None yet
4 participants
@ghost
Copy link

ghost commented Oct 27, 2015

When copy/pasting a tests, it is easy to forget (or not know) that the
port used must be unique to allow for multiple tests to run in
parallel (make -j8). Add a reminder next to each port.

Signed-off-by: Loic Dachary ldachary@redhat.com

@Vicente-Cheng

This comment has been minimized.

Copy link
Contributor

Vicente-Cheng commented Oct 27, 2015

LGTM!
useful reminder 👍

myabe the comment should be git grep '\<7109\>'
lost a '

anyway, that's a good reminder for me!!

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Oct 27, 2015

lgtm once the missing ' is added. and good catch, @Vicente-Cheng !

tests: port uniqueness reminder
When copy/pasting a tests, it is easy to forget (or not know) that the
port used must be unique to allow for multiple tests to run in
parallel (make -j8). Add a reminder next to each port.

Signed-off-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 27, 2015

Loic Dachary
Merge pull request #6387 from dachary/wip-test-ports
tests: port uniqueness reminder

Reviewed-by: Vicente Cheng <freeze.bilsted@gmail.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

@ghost ghost merged commit 870730e into ceph:master Oct 27, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.