Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librados: wrongly passed in argument for stat command #6476

Merged
merged 1 commit into from Nov 6, 2015

Conversation

Projects
None yet
4 participants
@xiexingguo
Copy link
Member

xiexingguo commented Nov 5, 2015

The first argument of io_ctx_impl->stat() requires an obj(of type object_t), but an oid(of type string) is directly passed in instead.
Fixes: #13703
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

librados: wrongly passed in argument for stat command
The first argument of io_ctx_impl->stat() requires an obj(of type object_t), but an oid(of type string) is directly passed in instead.
Fixes: #13703
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@xiexingguo

This comment has been minimized.

Copy link
Member Author

xiexingguo commented Nov 5, 2015

@tchaikov Would you please take a minute to review it for me? I guess this change is quite clear :)))

Thanks a lot.

@tchaikov tchaikov added the cleanup label Nov 5, 2015

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Nov 5, 2015

lgtm once the "make check" bot returns.

@xiexingguo

This comment has been minimized.

Copy link
Member Author

xiexingguo commented Nov 5, 2015

@tchaikov Well, I really consider this as a bug instead of some kind of cleanup if we don't stick into any details about this two structures.

@jdurgin

This comment has been minimized.

Copy link
Member

jdurgin commented Nov 5, 2015

The string argument gets implicitly converted to object_t here, so this shouldn't change behavior, just code clarity. This is the reason it's nice to have one argument constructors declared explicit.

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Nov 6, 2015

@xiexingguo, @jdurgin's explained why i attached the "cleanup" label to this pr.

tchaikov added a commit that referenced this pull request Nov 6, 2015

Merge pull request #6476 from xiexingguo/xxg-wip-13703
librados: wrongly passed in argument for stat command

Reviewed-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov merged commit 051a52e into ceph:master Nov 6, 2015

@xiexingguo xiexingguo deleted the xiexingguo:xxg-wip-13703 branch Nov 6, 2015

@xiexingguo

This comment has been minimized.

Copy link
Member Author

xiexingguo commented Nov 6, 2015

@tchaikov OK, thanks a lot.
Btw, http://tracker.ceph.com/issues/13703 can be rightfully closed now.

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Nov 6, 2015

thanks for the reminder. closed.

@xiexingguo xiexingguo referenced this pull request Nov 7, 2015

Merged

librados: do cleanup #6488

@ghost ghost added the core label Feb 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.