Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbdmap: systemd support #6479

Merged
merged 2 commits into from Nov 6, 2015

Conversation

Projects
None yet
6 participants
@b-ranto
Copy link
Contributor

b-ranto commented Nov 5, 2015

This PR should help us achieve full systemd support by adding an rbdmap systemd unit file. To achieve this, the map/unmap functionality was moved to src/rbdmap and the template config was moved to src/etc-rbdmap.

rbdmap: Move do_map and do_unmap shell functions to rbdmap script
This patch creates rbdmap shell script that is called from init-rbdmap
init script. The patch also renames src/rbdmap configuration file to
src/etc-rbdmap so that rbdmap shell script can be installed via build
system directly. Finally, the patch accomodates these changes in spec
file and build system.

Fixes: #13374
Signed-off-by: Boris Ranto <branto@redhat.com>

@b-ranto b-ranto referenced this pull request Nov 5, 2015

Closed

rbdmap: systemd support #6443

@b-ranto b-ranto force-pushed the wip-systemd-rbdmap branch from 231a750 to 5892d74 Nov 5, 2015

@b-ranto

This comment has been minimized.

Copy link
Contributor Author

b-ranto commented Nov 6, 2015

FYI: After the last update, the patches seem to pass the gitbuilders.

rbdmap: systemd support
Fixes: #13374
Signed-off-by: Boris Ranto <branto@redhat.com>

@b-ranto b-ranto force-pushed the wip-systemd-rbdmap branch from 5892d74 to 9224ac2 Nov 6, 2015

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Nov 6, 2015

lgtm.

liewegas added a commit that referenced this pull request Nov 6, 2015

Merge pull request #6479 from ceph/wip-systemd-rbdmap
rbdmap: systemd support

Reviewed-by: Kefu Chai <kchai@redhat.com>

@liewegas liewegas merged commit 24380c8 into master Nov 6, 2015

@liewegas liewegas deleted the wip-systemd-rbdmap branch Nov 6, 2015

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Nov 6, 2015

thanks, @branto1 !

@Kriechi

This comment has been minimized.

Copy link

Kriechi commented on src/rbdmap in c0980af Jul 6, 2016

This should probably be #!/bin/bash - otherwise the use of ${PARAMS[@]} might fail.

This comment has been minimized.

Copy link
Contributor

tchaikov replied Jul 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.