bluestore: fix two wal bugs; reuse OnodeRefs when applying txc #7486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
force-pushed
the
wip-bluestore-oref
branch
from
1d411d1
to
620d774
Compare
Do this in the caller to simplify the callees slightly. Signed-off-by: Sage Weil <sage@redhat.com>
If the wal write starts partway into the tail block, we need to allocate less than a full block. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Get OnodeRef ready in the caller, and keep it in a vector so that it can be reused for any subsequent operations in the transaction. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
If we set bdev_inject_crash, ensure we crash even if the device is idle. Signed-off-by: Sage Weil <sage@redhat.com>
msg/simple/Pipe.cc: In member function 'void Pipe::writer()':
msg/simple/Pipe.cc:1721:26: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
if(::write(sd, &tag, 1));
^
Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-bluestore-oref
branch
from
1b86827
to
abe31b1
Compare
This patch is mostly a wash, except that _rename now avoids doing the _do_remove() work in the case where the object didn't exist before. Reported-by: ie xingguo <xie.xingguo@zte.com.cn> Signed-off-by: Sage Weil <sage@redhat.com>
We were failing to set o->enode, which meant that there were multiple instances of the same enode alive at once. Avoid this category of bug by changing _txc_release to take the onode ref and assign it there, and removing almost all of the local EnodeRef instances. Signed-off-by: Sage Weil <sage@redhat.com>
|
@xiexingguo whoops! fixed, thanks for pointing it out |
This way we don't generate a core file, which spams the log and trips up teuthology. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
added a commit
that referenced
this pull request
Feb 6, 2016
osd: bluestore: fix two wal bugs; reuse OnodeRefs when applying txc Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.