mds: allow client to request caps when opening file #7952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow client to request xattrs while opening file. MDS adds xattrs and corresponding caps to the reply. This is important for selinux on kcephfs. Fixes: ceph#14360 Signed-off-by: Yan, Zheng <zyan@redhat.com>
|
This needs a qa-suite test. Also, it doesn't seem to include the bits for actually sending back xattrs on an open? |
|
the new line "mdr->getattr_caps = mask" in handle_client_open() does the trick |
|
Oh, because that's used in encode_inodestat() to include the xattrs on reply. Still needs a test though. :) |
Signed-off-by: Yan, Zheng <zyan@redhat.com>
|
Oh, didn't read closely enough. Looks like it just needs to run against a different conf file.
|
|
Pushed a quick change moving the test into multiclient and will test again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow client to request xattrs while opening file. MDS adds xattrs
and corresponding caps to the reply. This is important for selinux
on kcephfs.
Fixes: #14360
Signed-off-by: Yan, Zheng zyan@redhat.com