Be more verbose in radosgw init script issues, return the right exit codes #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Much needed for scripts to mange the service properly, Can we back port these to previous release too? |
|
Screwed up the branch, hang on. |
added 3 commits
November 5, 2013 11:32
An exit 0 means everything went okay - we should exit 1 if there is a problem in starting radosgw. Signed-off-by: David Moreau Simard <dmsimard@iweb.com>
Changed "/etc/init.d/radosgw status" into a function that now returns the appropriate exit code. We now also verify that radosgw actually started properly. Signed-off-by: David Moreau Simard <dmsimard@iweb.com>
This allows a user to use "-v|--verbose" to get some insight as to what could be preventing radosgw from starting properly. Signed-off-by: David Moreau Simard <dmsimard@iweb.com>
|
Sorry about that. Should be good now, what do you think ? |
yehudasa
added a commit
that referenced
this pull request
Nov 5, 2013
Be more verbose in radosgw init script issues, return the right exit codes Reviewed-by: Yehuda Sadeh <yehuda@inktank.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: http://tracker.ceph.com/issues/6710
Before, we would exit 0 where we should exit 1 or use "continue".
This means we were not returning exit 1 if there was an error and
radosgw did not start.
This commit aims to handle theses cases better.
We also now verify that radosgw started successfully.