Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/OSD.h: remove unneeded line #8980

Merged
merged 1 commit into from Jul 6, 2016

Conversation

Projects
None yet
7 participants
@stiopaa1
Copy link
Contributor

commented May 6, 2016

We don't need to create a key with value 0 here.
It is created in statement:
pgid_tracker[pgid]++
if it doesnt exist.

Signed-off-by: Michal Jarzabek stiopa@gmail.com

osd/OSD.h: remove unneeded line
We don't need to create a key with value 0 here.
It is created in statement:
pgid_tracker[pgid]++
if it doesnt exist.

Signed-off-by: Michal Jarzabek <stiopa@gmail.com>
@xiexingguo

This comment has been minimized.

Copy link
Member

commented May 7, 2016

lgtm

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented May 9, 2016

lgtm also

@liewegas

This comment has been minimized.

Copy link
Member

commented May 9, 2016

  map<spg_t, int> pgid_tracker;

are you sure that the value is reliably initialized to 0, given that int has no ctor?

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented May 9, 2016

If an insertion is performed, the mapped value is value-initialized (default-constructed for class types, zero-initialized otherwise) and a reference to it is returned.

@athanatos athanatos added the needs-qa label Jun 8, 2016

@jdurgin jdurgin merged commit 3134a2d into ceph:master Jul 6, 2016

1 of 2 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.