Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: rbd: don't modprobe, chown sysfs files or udevadm settle #9123

Merged
merged 3 commits into from May 13, 2016

Conversation

idryomov
Copy link
Contributor

No description provided.

This is a followup to 38a5720 ("qa: rbd/map-snapshot-io.sh: don't
chown sysfs files") for the rest of the workunits:

- /sys/bus/rbd/add_single_major is used if present, so chown'ing
  /sys/bus/rbd/add doesn't help.  Use sudo on rbd map instead.

- Don't modprobe or udevadm settle - rbd CLI tool takes care of that.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
rbd_map_image() echoes the id of the image and is used in command
substitution:

    id=$(rbd_map_image "${image}")

Output from rbd map isn't consumed and clobbers the return.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
@dillaman dillaman merged commit cd72952 into ceph:master May 13, 2016
@lande1234
Copy link
Contributor

@idryomov @dillaman
HI!
I have a question that why we drop the sudo.
when i test the rbd_simple_big.yaml suite i have meet zhe permission's problem.

the wrong list:
`2016-07-16T15:47:35.430 INFO:tasks.workunit.client.0.plana121.stderr:+ dd if=/dev/zero of=/dev/rbd0 bs=1M count=100000
2
2016-07-16T15:47:35.432 INFO:tasks.workunit.client.0.plana121.stderr:dd: failed to open 鈥�/dev/rbd0鈥�: Permission denied

2016-07-16T15:47:35.432 INFO:tasks.workunit:Stopping ['rbd/simple_big.sh'] on client.0...`

@idryomov
Copy link
Contributor Author

@lande1234 Which lab is this? Need to make sure teuthology user is added to the "disk" group.

@lande1234
Copy link
Contributor

@idryomov when I set up the teuthology frame according to zhe teuthology doc ,I didn't notice that how to add zhe user to zhe 'disk' group. can you explain it or give a link to me? thanks!

@idryomov
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants