New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fix memory leak in copy_obj_to_remote_dest #9974

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
8 participants
@weiqiaomiao
Contributor

weiqiaomiao commented Jun 28, 2016

Signed-off-by: weiqiaomiao wei.qiaomiao@zte.com.cn

@@ -6826,6 +6826,7 @@ int RGWRados::copy_obj_to_remote_dest(RGWObjState *astate,
ret = read_op.iterate(0, astate->size - 1, out_stream_req->get_out_cb());
if (ret < 0)
delete out_stream_req;
return ret;

This comment has been minimized.

@gaowanlong

gaowanlong Jun 28, 2016

Contributor

You are missing the " { } " for "if" statement here.

rgw: fix memory leak in copy_obj_to_remote_dest
Signed-off-by: weiqiaomiao <wei.qiaomiao@zte.com.cn>
@weiqiaomiao

This comment has been minimized.

Contributor

weiqiaomiao commented Jun 28, 2016

thanks @gaowanlong . I fix it

@weiqiaomiao

This comment has been minimized.

Contributor

weiqiaomiao commented Aug 6, 2016

retest this please

@weiqiaomiao

This comment has been minimized.

Contributor

weiqiaomiao commented Aug 24, 2016

@liewegas liewegas added needs-qa and removed wip-matt-testing labels Mar 28, 2017

@oritwas oritwas self-assigned this Apr 3, 2017

@oritwas

oritwas approved these changes Apr 3, 2017

@yuriw

This comment has been minimized.

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jul 13, 2017

jenkins test this please

@yehudasa yehudasa merged commit feb998d into ceph:master Jul 13, 2017

3 of 5 checks passed

make check running make check
Details
make check (arm64) Build triggered. sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
@yehudasa

This comment has been minimized.

Member

yehudasa commented Jul 13, 2017

@weiqiaomiao @oritwas see #16324, a fix in a related code (noticed it when reviewing this one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment