ceph_orch_host: fix type for parameter 'labels' #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter should support passing either a 'str' or a list of 'str'. without that change, if you pass 'labels: ceph' it will end up to the following situation: ``` Added label c to host rhceph5x-5node-1 Added label e to host rhceph5x-5node-1 Added label p to host rhceph5x-5node-1 Added label h to host rhceph5x-5node-1 ``` Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2103673 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
force-pushed
the
support-str-and-list
branch
from
637338d
to
9d47e85
Compare
This was referenced Jul 4, 2022
guits
added a commit
that referenced
this pull request
Jul 4, 2022
ceph_orch_host: fix type for parameter 'labels' (backport #138)
guits
added a commit
that referenced
this pull request
Jul 4, 2022
ceph_orch_host: fix type for parameter 'labels' (backport #138)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter should support passing either a 'str' or a list of
'str'.
without that change, if you pass 'labels: ceph'
it will end up to the following situation:
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2103673
Signed-off-by: Guillaume Abrioux gabrioux@redhat.com