switch instrumentation from execute_with_consistency to execute_with_options #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged! Thanks for correcting the instrumentation. |
|
Released in 1.9.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I hadn't ever gotten the new relic instrumentation to work, but I attributed it to configuration issues. After diving in, I found that the changes I made a few months ago to support pagination may have broken the usefulness of instrumenting
execute_with_consistencysince it is now only used when doing batch queries.Since
execute_with_consistencycallsexecute_with_options, I thought it would make sense to change the instrumented method. Trying it out locally, I was able to start seeing metrics and transaction segments for Cequel, as I never had before.