Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch instrumentation from execute_with_consistency to execute_with_options #300

Merged
merged 1 commit into from May 15, 2016

Conversation

bettse
Copy link
Contributor

@bettse bettse commented May 13, 2016

I hadn't ever gotten the new relic instrumentation to work, but I attributed it to configuration issues. After diving in, I found that the changes I made a few months ago to support pagination may have broken the usefulness of instrumenting execute_with_consistency since it is now only used when doing batch queries.

Since execute_with_consistency calls execute_with_options, I thought it would make sense to change the instrumented method. Trying it out locally, I was able to start seeing metrics and transaction segments for Cequel, as I never had before.

@pezra pezra merged commit fee33c8 into cequel:master May 15, 2016
1 check passed
@pezra
Copy link
Contributor

@pezra pezra commented May 15, 2016

Merged! Thanks for correcting the instrumentation.

@pezra
Copy link
Contributor

@pezra pezra commented May 16, 2016

Released in 1.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants