Skip to content

fix(sdk): set correct unique value for mids with set relation#730

Merged
smrz2001 merged 2 commits into
mainfrom
fix/set-relation
Aug 10, 2025
Merged

fix(sdk): set correct unique value for mids with set relation#730
smrz2001 merged 2 commits into
mainfrom
fix/set-relation

Conversation

@smrz2001

Copy link
Copy Markdown
Contributor

Please also review DX for improvements.

@smrz2001 smrz2001 self-assigned this Jul 30, 2025
@smrz2001 smrz2001 requested a review from a team as a code owner July 30, 2025 19:26
@smrz2001 smrz2001 requested review from ukstv and removed request for a team July 30, 2025 19:26
@smrz2001 smrz2001 temporarily deployed to tnet-prod-2024 July 30, 2025 19:47 — with GitHub Actions Inactive

@stephhuynh18 stephhuynh18 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what i can see it looks fine but also i'm def not the best person

- Replace 'any' types with proper TypeScript types
- Use Record<string, unknown> for generic object typing
- Add proper type imports for test mocks (CeramicClient, DID, StreamState)
- Change encodeMultibase parameter type from 'any' to 'unknown'
- Improve code formatting for better readability

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@smrz2001 smrz2001 enabled auto-merge August 10, 2025 11:38
@smrz2001 smrz2001 added this pull request to the merge queue Aug 10, 2025
Merged via the queue into main with commit 2e5c7a7 Aug 10, 2025
20 checks passed
@smrz2001 smrz2001 deleted the fix/set-relation branch August 10, 2025 13:02
@smrz2001 smrz2001 mentioned this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants