chore(test): Update Minio config in tests #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blob store tests have started failing because the new release of Minio container is checking the data directory for IO-DIRECT access. Switching to the default `/data` directory seems to fix this issue. In addition, the healthcheck should be using the readiness probe instead of the liveness probe because sometimes the server is not yet ready to accept connections even if it is up. Also reduces the parallelism in E2E test runs because lately they have been failing -- possibly due to resource contention. Signed-off-by: Charith Ellawala <charith@cerbos.dev>
Codecov Report
@@ Coverage Diff @@
## main #965 +/- ##
==========================================
+ Coverage 54.47% 55.02% +0.55%
==========================================
Files 106 106
Lines 11440 11636 +196
==========================================
+ Hits 6232 6403 +171
- Misses 4683 4704 +21
- Partials 525 529 +4
|
haines
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blob store tests have started failing because the new release of
Minio container is checking the data directory for IO-DIRECT access.
Switching to the default
/datadirectory seems to fix this issue.In addition, the healthcheck should be using the readiness probe instead
of the liveness probe because sometimes the server is not yet ready to
accept connections even if it is up.
Also reduces the parallelism in E2E test runs because lately they have
been failing -- possibly due to resource contention.
Signed-off-by: Charith Ellawala charith@cerbos.dev