Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit missing from release 0.8.0 gem. #862

Closed
jimsynz opened this issue Oct 5, 2016 · 1 comment
Closed

commit missing from release 0.8.0 gem. #862

jimsynz opened this issue Oct 5, 2016 · 1 comment

Comments

@jimsynz
Copy link
Contributor

jimsynz commented Oct 5, 2016

Hi there.

I ran into an issue where resources routes are throwing 500's for some mounted engines, and eventually found my way back to ed05887 which fixes the issue. What's interesting about this is that I am running 0.8.0 in my project:

$ gem pristine jsonapi-resources
Restoring gems to pristine condition...
Restored jsonapi-resources-0.8.0
$ at "$(bundle show jsonapi-resources)/lib/jsonapi/link_builder.rb" | grep -A6 def\ engine_resources_path_name_from_class
    def engine_resources_path_name_from_class(klass)
      scopes         = module_scopes_from_class(klass)[1..-1]
      base_path_name = scopes.map { |scope| scope.underscore }.join("_")
      end_path_name  = klass._type.to_s
      "#{ base_path_name }_#{ end_path_name }_path"
    end

According to the compare view, the change in question is in the v0.8.0 tag.

@lgebhardt
Copy link
Member

Should be fixed with the 0.8.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants