Clarify remaining uses of nondeterministic functions #261

Open
nh2 opened this Issue Mar 23, 2017 · 2 comments

Comments

Projects
None yet
2 participants

nh2 commented Mar 23, 2017

@sandwichmaker In https://ceres-solver.googlesource.com/ceres-solver/+/36c73c26bb3fd9b319435aa9702a110678239d9c you write:

I have chosen not to delete the existing unstable implementations of these functions as they are used by the inner iteration minimizer.

Sometime in the near future I will clean up some of the duplicate code and see if we can move all the code to using a stable ordering.

In which part of the code are the unstable implementations still used? Grepping for ComputeSchurOrdering in commit 36c73c2, there seems to be no use of it besides in tests.

nh2 commented Mar 23, 2017

(Asking this because I've encountered nondeterminism when using the automatic inner iteration ordering.)

sandwichmaker self-assigned this Mar 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment