New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++17 removes random_shuffle breaks ceres-solver #373
Comments
|
@NeroBurner that line can likely just be dropped. Please feel free to send a CL. |
NeroBurner
pushed a commit
to NeroBurner/hunter
that referenced
this issue
May 18, 2018
|
@sandwichmaker you mean removing the chunk shuffling altogether or just replacing it with C++11's |
keir
pushed a commit
that referenced
this issue
May 23, 2018
std::random_shuffle() is deprecated since C++14 and was removed in C++17. At least MSVC with C++17 fails to compile this code, I assume other compilers fail as well. In a Github discussion (#373) Sameer Agarwal states this line can likely be dropped and asks for a PR/CL. #373 Change-Id: I78e04f36cba398769b8f90916edbdaf33884e7e1
NeroBurner
pushed a commit
to NeroBurner/ceres-solver
that referenced
this issue
Dec 10, 2018
std::random_shuffle() is deprecated since C++14 and was removed in C++17. At least MSVC with C++17 fails to compile this code, I assume other compilers fail as well. In a Github discussion (ceres-solver#373) Sameer Agarwal states this line can likely be dropped and asks for a PR/CL. ceres-solver#373 Change-Id: I78e04f36cba398769b8f90916edbdaf33884e7e1
NeroBurner
pushed a commit
to NeroBurner/ceres-solver
that referenced
this issue
Dec 10, 2018
std::random_shuffle() is deprecated since C++14 and was removed in C++17. At least MSVC with C++17 fails to compile this code, I assume other compilers fail as well. In a Github discussion (ceres-solver#373) Sameer Agarwal states this line can likely be dropped and asks for a PR/CL. ceres-solver#373 Change-Id: I78e04f36cba398769b8f90916edbdaf33884e7e1
NikolausDemmel
pushed a commit
to NikolausDemmel/ceres-solver
that referenced
this issue
Aug 19, 2020
std::random_shuffle() is deprecated since C++14 and was removed in C++17. At least MSVC with C++17 fails to compile this code, I assume other compilers fail as well. In a Github discussion (ceres-solver#373) Sameer Agarwal states this line can likely be dropped and asks for a PR/CL. ceres-solver#373 Change-Id: I78e04f36cba398769b8f90916edbdaf33884e7e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ceres-Solver with C++17 won't compile.
C++14 deprecates
random_shuffle, C++17 removesrandom_shuffleAs replacement since C++11
std::shuffleis providedSource: http://en.cppreference.com/w/cpp/algorithm/random_shuffle
In current master only
schur_eliminator_impl.hseems to use random_shuffleceres-solver/internal/ceres/schur_eliminator_impl.h
Line 155 in 5d8b494
Since 282b8b5 ceres-solver requires at least C++11. Therefore this change should make no problems
CC: @norbertwenzel
The text was updated successfully, but these errors were encountered: