Compatibility with Tapeline mod #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes compatbility with Tapeline and any other mods that may be placing similar types of ghost entities.
- This is specifically related to selection tools that place entities as they are being dragged on top of the unapproved ghosts, but only in cases where the resulting entities built by such selection tools would be marked as non-selectable in game. - Fixes compatibility with Tapeline mod, where the Tapeline selection tool would inadeverently approve the ghosts over which it is dragged.
ceresward
approved these changes
Aug 13, 2022
|
I'll close off this pull request just so it does not accidentally get merged (it'll make it a bit harder for me to then merge the fork back into this one). Probably should get off my behind and finally get the fork merged, migrated and closed off, I think it's just going to require a single migration similar to what already exists for the other way around :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this pull request is to fix compatibility with the Tapeline mod.
Tapeline mode creates temporary entities as player is drawing the tapelines using the tapeline selection tool.
When such entities are placed when auto-approvals are disabled by Construction Planner, they end-up being picked up as normal ghosts, and leave "phantom" ghost placeholders that can never be built. This problem is solved by adding checks to Construction Planner to see if the ghosts are marked as selectable (Tapeline marks such entities as non-selectable).
The other problem is when Tapeline is dragged over the existing unapproved ghosts. In that case the unapproved ghosts are approved by mistake during the invocation of
on_pre_buildevent handler (as Tapeline's ghost entities are getting built on the surface). This one is a bit trickier to fix, but I think the proposed commit should be a good enough solution (checking if player is holding selection tool and if that selection tools places non-selectable entities/ghosts).