Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix foodcritic 2x #47

Merged
merged 2 commits into from Apr 19, 2017
Merged

Fix foodcritic 2x #47

merged 2 commits into from Apr 19, 2017

Conversation

@bbaugher
Copy link
Member

bbaugher commented Apr 18, 2017

Test Kitchen Evidence: https://gist.github.com/bbaugher/a52e4d65317f97be2a93ec868e11f4ef

Same as #46 but also hit FC074 to use default_action method on our resource

@stefanmendoza

This comment has been minimized.

Copy link

stefanmendoza commented Apr 19, 2017

+1

1 similar comment
@mkwhitacre

This comment has been minimized.

Copy link
Member

mkwhitacre commented Apr 19, 2017

+1

@bbaugher

This comment has been minimized.

Copy link
Member Author

bbaugher commented Apr 19, 2017

Have enough +1s, merging

@bbaugher bbaugher merged commit e7a97e1 into 2.x Apr 19, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
description 'Installs/Configures tomcat'
long_description 'This cookbook is meant to install and configure an instance of tomcat'
issues_url 'https://github.com/cerner/cerner_tomcat/issues'
source_url 'https://github.com/cerner/cerner_tomcat'
name 'cerner_tomcat'

chef_version '>= 12.0' if respond_to?(:chef_version)

This comment has been minimized.

Copy link
@bjtieman

bjtieman Apr 19, 2017

Contributor

What's the purpose of the respond_to? Why can't we just specify ">= 12.0"? And actually, given the problems we've encountered recently with Chef 13 should we just have "~ 12.0" for now?

This comment has been minimized.

Copy link
@bbaugher

bbaugher Apr 19, 2017

Author Member

the purpose of respond_to is to handle situations where the version of chef doesn't have a chef_version method for metadata.rb which looks to have been added in 12.6. Currently this cookbook and its dependencies have no problems with Chef 13, our test kitchen runs still work fine so I left it open so we don't have to tweak and release it later

This comment has been minimized.

Copy link
@bjtieman

bjtieman Apr 19, 2017

Contributor

+1...thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.