Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat Reconciler response with RequeueAfter>0 also meaning Requeue=true #38

Merged
merged 1 commit into from Oct 21, 2021
Merged

Treat Reconciler response with RequeueAfter>0 also meaning Requeue=true #38

merged 1 commit into from Oct 21, 2021

Conversation

JoshVanL
Copy link
Contributor

Currently in Ready responses, RequeueAfter is only considered if Requeue is also true. This PR changes this behaviour so that RequeueAfter > 0 always implies Requeue = true, matching controller-runtime.

/assign @wallrj

Ready Responses now treat `Requeue After` with a larger than 0 value to always mean `Requeue = true`

@JoshVanL
Treat Reconciler response with RequeueAfter>0 also meaning
020f040 
Requeue=true

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2021
wallrj
wallrj approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JoshVanL

This behaviour makes sense and is familiar to me.
The new unit-test makes sense too.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit ce28c2e into cert-manager:main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallrj wallrj wallrj approved these changes

Assignees

@wallrj wallrj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoshVanL @jetstack-bot @wallrj