Detect multiple certs pointed to the same secret

[gregsidelinger]

Is your feature request related to a problem? Please describe.
If two certs are pointed at the same secret cert-manager will go into a cert ordering loop as the secret's never match what the other cert expects.

Here is a log example of that happening

I0522 15:06:45.930979       1 controller.go:141] cert-manager/controller/certificates "msg"="syncing item" "key"="default/example-cert1"
I0522 15:06:45.931688       1 sync.go:304] cert-manager/controller/certificates "msg"="updated Secret resource metadata as it was out of date" "related_resource_kind"="Secret" "related_resource_name"="example-cert2" "related_resource_namespace"="default" "resource_kind"="Certificate" "resource_name"="example-cert2" "resource_namespace"="default"
I0522 15:06:45.931840       1 util.go:178] cert-manager/controller/certificates "msg"="certificate scheduled for renewal" "duration_until_renewal"="16781h10m11.068183419s" "related_resource_kind"="Secret" "related_resource_name"="example-cert2" "related_resource_namespace"="default" "resource_kind"="Certificate" "resource_name"="example-cert2" "resource_namespace"="default"
I0522 15:06:45.931896       1 sync.go:311] cert-manager/controller/certificates "msg"="certificate does not require re-issuance. certificate renewal scheduled near expiry time." "related_resource_kind"="Secret" "related_resource_name"="example-cert2" "related_resource_namespace"="default" "resource_kind"="Certificate" "resource_name"="example-cert2" "resource_namespace"="default"
I0522 15:06:45.932245       1 controller.go:147] cert-manager/controller/certificates "msg"="finished processing work item" "key"="default/example-cert2"
I0522 15:06:45.932275       1 controller.go:141] cert-manager/controller/certificates "msg"="syncing item" "key"="default/example-cert2"
I0522 15:06:45.932700       1 util.go:178] cert-manager/controller/certificates "msg"="certificate scheduled for renewal" "duration_until_renewal"="16781h10m11.067322348s" "related_resource_kind"="Secret" "related_resource_name"="example-cert2" "related_resource_namespace"="default" "resource_kind"="Certificate" "resource_name"="example-cert2" "resource_namespace"="default"
I0522 15:06:45.932733       1 sync.go:311] cert-manager/controller/certificates "msg"="certificate does not require re-issuance. certificate renewal scheduled near expiry time." "related_resource_kind"="Secret" "related_resource_name"="example-cert2" "related_resource_namespace"="default" "resource_kind"="Certificate" "resource_name"="example-cert2" "resource_namespace"="default"
I0522 15:06:45.933006       1 controller.go:147] cert-manager/controller/certificates "msg"="finished processing work item" "key"="default/example-cert2"


I0522 15:06:45.530648       1 controller.go:141] cert-manager/controller/certificates "msg"="syncing item" "key"="default/example-cert2"
I0522 15:06:45.531642       1 sync.go:304] cert-manager/controller/certificates "msg"="updated Secret resource metadata as it was out of date" "related_resource_kind"="CertificateRequest" "related_resource_name"="example-cert1-3874364632" "related_resource_namespace"="default" "resource_kind"="Certificate" "resource_name"="example-cert1" "resource_namespace"="default"
I0522 15:06:45.531787       1 util.go:178] cert-manager/controller/certificates "msg"="certificate scheduled for renewal" "duration_until_renewal"="16781h10m11.468236881s" "related_resource_kind"="Secret" "related_resource_name"="example-cert2" "related_resource_namespace"="default" "resource_kind"="Certificate" "resource_name"="example-cert1" "resource_namespace"="default"
I0522 15:06:45.531817       1 sync.go:311] cert-manager/controller/certificates "msg"="certificate does not require re-issuance. certificate renewal scheduled near expiry time." "related_resource_kind"="CertificateRequest" "related_resource_name"="example-cert1-3874364632" "related_resource_namespace"="default" "resource_kind"="Certificate" "resource_name"="example-cert1" "resource_namespace"="default"
I0522 15:06:45.532234       1 controller.go:147] cert-manager/controller/certificates "msg"="finished processing work item" "key"="default/example-cert1"
I0522 15:06:45.532263       1 controller.go:141] cert-manager/controller/certificates "msg"="syncing item" "key"="default/example-cert1"
I0522 15:06:45.532697       1 util.go:178] cert-manager/controller/certificates "msg"="certificate scheduled for renewal" "duration_until_renewal"="16781h10m11.4673245s" "related_resource_kind"="Secret" "related_resource_name"="example-cert2" "related_resource_namespace"="default" "resource_kind"="Certificate" "resource_name"="example-cert1" "resource_namespace"="default"
I0522 15:06:45.532728       1 sync.go:311] cert-manager/controller/certificates "msg"="certificate does not require re-issuance. certificate renewal scheduled near expiry time." "related_resource_kind"="CertificateRequest" "related_resource_name"="example-cert1-3874364632" "related_resource_namespace"="default" "resource_kind"="Certificate" "resource_name"="example-cert1" "resource_namespace"="default"
I0522 15:06:45.533035       1 controller.go:147] cert-manager/controller/certificates "msg"="finished processing work item" "key"="default/example-cert1"

Describe the solution you'd like
Detect this setup refuse to order new certs. Maybe send some events to the certs in question.

Describe alternatives you've considered
Make users smarter so they don't do stupid things.

Environment details (if applicable):

• Kubernetes version (e.g. v1.10.2): 1.14.8
• Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): AWS
• cert-manager version (e.g. v0.15.0): v0.15.0
• Install method (e.g. helm or static manifests): helm

/kind feature

[hzhou97]

/area monitoring
/priority important-longterm

[jetstack-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

[jetstack-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle rotten
/remove-lifecycle stale

[jetstack-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

[jetstack-bot]

@jetstack-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gregsidelinger]

/reopen

[jetstack-bot]

@gregsidelinger: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jetstack-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

[jetstack-bot]

@jetstack-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gregsidelinger]

/reopen

[jetstack-bot]

@gregsidelinger: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jetstack-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

[jetstack-bot]

@jetstack-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to jetstack.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.