Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run-dev-kind instructions #2074

Merged
merged 1 commit into from Sep 16, 2019

Conversation

srvaroa
Copy link
Contributor

@srvaroa srvaroa commented Sep 16, 2019

The charts path was out of date.

Update `hack/ci/run-dev-kind.sh` script to use the right path of cert-manager charts.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 16, 2019
@jetstack-bot jetstack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 16, 2019
@jetstack-bot
Copy link
Collaborator

Hi @srvaroa. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 16, 2019
The charts path was out of date.

Signed-off-by: Galo Navarro <anglorvaroa@gmail.com>
@JoshVanL
Copy link
Collaborator

Thanks! Can you add a release note? :

```release-note
NONE
```

/ok-to-test
/approve
/assign @srvaroa

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 16, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, srvaroa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 16, 2019
@srvaroa
Copy link
Contributor Author

srvaroa commented Sep 16, 2019

Thanks @JoshVanL !

@JoshVanL
Copy link
Collaborator

Github still seems resolvable to me 🙃
/retest
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2019
@JoshVanL
Copy link
Collaborator

argh
/retest

@jetstack-bot jetstack-bot merged commit 49d4022 into cert-manager:master Sep 16, 2019
@jetstack-bot jetstack-bot added this to the v0.11 milestone Sep 16, 2019
@munnerz munnerz added this to Done in v0.11 Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
No open projects
v0.11
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants