Implement the DNS-over-HTTPS check #5003

FlorianLiebhart · 2022-03-30T09:33:54Z

Pull Request Motivation

If cert-manager is run inside a network from which it is not possible to do TXT DNS entry checks, e.g. because the network does not allow DNS lookups on port 53 or because it has a different DNS view on the same domain (aka DNS split horizon view), which is not an uncommon setup, changes made to public DNS provider wont be visible from the inside and the DNS solver propagation checks never succeed.

This change adds a new way to check for DNS propagation with
the help of DNS over HTTPS resolvers. In the current form it implements the DNS Wire format, as defined in RFC 8484.

The DNS check method to be used is controlled by making use of the --dns01-recursive-nameservers-only=true flag in order to specify to use the defined recursive name servers only, as well as the --dns01-recursive-nameservers flag, for which the implementation has been slightly extended to also take DoH endpoints, like the following:
--dns01-recursive-nameservers=https://8.8.8.8/dns-query.

Thanks @redbaron for your original idea and contribution regarding this feature, which I have built upon!
And thanks especially a lot to @maelvls and @inteon for your great great great help during this PR!! :)

Kind

feature

Release Note

DNS over HTTPS (DoH) is now possible for doing the self-checks during the ACME verification.
The DNS check method to be used is controlled through the command line flag: `--dns01-recursive-nameservers-only=true` in combination with `--dns01-recursive-nameservers=https://<DoH-endpoint>` (e.g. `https://8.8.8.8/dns-query`). It keeps using DNS lookup as a default method.

jetstack-bot · 2022-03-30T09:34:04Z

Hi @FlorianLiebhart. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jakexks · 2022-04-04T12:48:46Z

Thanks for reaching out in the dev slack. I'll enable the CI tests.

/ok-to-test

FlorianLiebhart · 2022-04-04T18:03:20Z

/retest-required

FlorianLiebhart · 2022-04-04T18:51:09Z

/retest-required

FlorianLiebhart · 2022-04-04T22:56:47Z

/retest-required

FlorianLiebhart · 2022-04-04T23:23:01Z

/retest-required

FlorianLiebhart · 2022-04-04T23:36:46Z

/retest-required

FlorianLiebhart · 2022-04-05T07:21:39Z

/retest-required

Signed-off-by: Florian Liebhart <flo.liebhart@gmail.com>

jetstack-bot · 2023-06-20T13:48:29Z

@FlorianLiebhart: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cert-manager-master-e2e-v1-25	`9c0c120`	link	true	`/test pull-cert-manager-master-e2e-v1-25`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cmd/controller/app/options/options.go

Signed-off-by: Florian Liebhart <flo.liebhart@gmail.com>

maelvls · 2023-06-20T15:47:53Z

Great work. I'm totally OK with the fact that we don't have any tests that use BIND, I think the "live" unit tests that call out to https://1.1.1.1/dns-query are totally fine.

That said, I am worried that we haven't tested querying TXT and CNAME records, but I feel confident that testing A and CAA is enough.

/lgtm

maelvls · 2023-06-20T15:51:43Z

/unhold

maelvls · 2023-06-20T15:52:29Z

Next step: write the documentation! ✨🎉📖

FlorianLiebhart · 2023-06-20T18:45:56Z

@Galphaa @muffl0n @hvpareja and everyone else who was interested in these changes:
--> Great news! This PR is now merged!! :) 🥳 🎉

@maelvls also just created an alpha release, which can be used from now on! :)

Here it is: https://github.com/cert-manager/cert-manager/releases/tag/v1.13.0-alpha.0

All the best, have fun, and thanks sooo much to @maelvls for your BIG contribution and for pushing this change forward and for your great documentation skills! Not possible without you!
and to @inteon For your great help and big contribution and improvements these past days!!
Very happy! :)

hvpareja · 2023-06-20T20:33:15Z

Thanks a lot for the great job @FlorianLiebhart !

muffl0n · 2023-06-21T07:20:57Z

Awesome! Thank you very much! This works like a charm! 😍
I'm getting some weird log messages, though:

I0621 07:14:12.406491       1 trigger_controller.go:194] "cert-manager/certificates-trigger: Certificate must be re-issued" key="default/doh" reason="DoesNotExist" message="Issuing certificate as Secret does not exist"
I0621 07:14:12.406504       1 conditions.go:203] Setting lastTransitionTime for Certificate "doh" condition "Ready" to 2023-06-21 07:14:12.406490562 +0000 UTC m=+122.321224672
I0621 07:14:12.406536       1 conditions.go:203] Setting lastTransitionTime for Certificate "doh" condition "Issuing" to 2023-06-21 07:14:12.406532541 +0000 UTC m=+122.321266651
I0621 07:14:12.435328       1 controller.go:162] "cert-manager/certificates-trigger: re-queuing item due to optimistic locking on resource" key="default/doh" error="Operation cannot be fulfilled on certificates.cert-manager.io \"doh\": the object has been modified; please apply your changes to the latest version and try again"
I0621 07:14:12.435402       1 trigger_controller.go:194] "cert-manager/certificates-trigger: Certificate must be re-issued" key="default/doh" reason="DoesNotExist" message="Issuing certificate as Secret does not exist"
I0621 07:14:12.435422       1 conditions.go:203] Setting lastTransitionTime for Certificate "doh" condition "Issuing" to 2023-06-21 07:14:12.435417111 +0000 UTC m=+122.350151218
I0621 07:14:12.906043       1 conditions.go:263] Setting lastTransitionTime for CertificateRequest "doh-rlg6s" condition "Approved" to 2023-06-21 07:14:12.906031105 +0000 UTC m=+122.820765217
I0621 07:14:12.931793       1 conditions.go:263] Setting lastTransitionTime for CertificateRequest "doh-rlg6s" condition "Ready" to 2023-06-21 07:14:12.931780358 +0000 UTC m=+122.846514465
I0621 07:15:22.411445       1 acme.go:233] "cert-manager/certificaterequests-issuer-acme/sign: certificate issued" resource_name="doh-rlg6s" resource_namespace="default" resource_kind="CertificateRequest" resource_version="v1" related_resource_name="doh-rlg6s-879856528" related_resource_namespace="default" related_resource_kind="Order" related_resource_version="v1"
I0621 07:15:22.411566       1 conditions.go:252] Found status change for CertificateRequest "doh-rlg6s" condition "Ready": "False" -> "True"; setting lastTransitionTime to 2023-06-21 07:15:22.411547187 +0000 UTC m=+192.326281285
I0621 07:15:22.461017       1 conditions.go:192] Found status change for Certificate "doh" condition "Ready": "False" -> "True"; setting lastTransitionTime to 2023-06-21 07:15:22.461008161 +0000 UTC m=+192.375742255
I0621 07:15:22.477386       1 controller.go:162] "cert-manager/certificates-readiness: re-queuing item due to optimistic locking on resource" key="default/doh" error="Operation cannot be fulfilled on certificates.cert-manager.io \"doh\": the object has been modified; please apply your changes to the latest version and try again"
I0621 07:15:22.478231       1 conditions.go:192] Found status change for Certificate "doh" condition "Ready": "False" -> "True"; setting lastTransitionTime to 2023-06-21 07:15:22.47822114 +0000 UTC m=+192.392955247
I0621 07:15:22.498381       1 controller.go:162] "cert-manager/certificates-key-manager: re-queuing item due to optimistic locking on resource" key="default/doh" error="Operation cannot be fulfilled on certificates.cert-manager.io \"doh\": the object has been modified; please apply your changes to the latest version and try again"
I0621 07:15:22.502347       1 controller.go:162] "cert-manager/certificates-issuing: re-queuing item due to optimistic locking on resource" key="default/doh" error="Operation cannot be fulfilled on certificates.cert-manager.io \"doh\": the object has been modified; please apply your changes to the latest version and try again"
E0621 07:15:22.894995       1 sync.go:73] "cert-manager/orders: failed to update status" resource_name="doh-rlg6s-879856528" resource_namespace="default" resource_kind="Order" resource_version="v1"
I0621 07:15:22.895037       1 controller.go:162] "cert-manager/orders: re-queuing item due to optimistic locking on resource" key="default/doh-rlg6s-879856528" error="Operation cannot be fulfilled on orders.acme.cert-manager.io \"doh-rlg6s-879856528\": the object has been modified; please apply your changes to the latest version and try again"
E0621 07:15:22.912612       1 controller.go:208] "cert-manager/challenges: challenge in work queue no longer exists" err="challenge.acme.cert-manager.io \"doh-rlg6s-879856528-2980398084\" not found"

For example, I cannot recall if I saw

"Operation cannot be fulfilled on certificates.cert-manager.io \"doh\": the object has been modified; please apply your changes to the latest version and try again"

before.

inteon · 2023-06-21T07:41:20Z

@muffl0n that warning is unrelated to this PR. We have an alpha feature gate that fixes these warnings: ServerSideApply.
Feel free to check it out: https://github.com/cert-manager/cert-manager/blob/2417132b3cd017b5f0974006e03c2b8a540efe3f/internal/controller/feature/features.go#LL53C1-L53C1

muffl0n · 2023-06-21T07:53:20Z

Thanks for the clarification! With ServerSideApply everything looks fine.

FlorianLiebhart · 2023-06-21T07:54:10Z

@muffl0n! Very happy it works for you, thanks for the positive feedback! :)
So your certificates get issued and stored in secrets, as it seems.

As @inteon already said, the error message you see does not have anything to do with the changes made in my PR, as the part that was changed was not very invasive.

Also, the error message you see is actually on info level and is something that seems to have been around already for a few years.
After googling for it, I see it mentioned in two old Github issues already:

And seems to have (not?) been resolved in this PR: #3794
As mentioned in the release notes of Cert-Manager here: https://cert-manager.io/docs/release-notes/release-notes-1.4/
(on that page, search for "optimistic locking" to find it).

Luckily, @inteon had the solution for you already. Great!:)

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cert-manager](https://github.com/cert-manager/cert-manager) | minor | `v1.12.4` -> `v1.13.0` | --- ### Release Notes <details> <summary>cert-manager/cert-manager (cert-manager)</summary> ### [`v1.13.0`](https://github.com/cert-manager/cert-manager/releases/tag/v1.13.0) [Compare Source](cert-manager/cert-manager@v1.12.4...v1.13.0) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. This is the 1.13 release of cert-manager! #### Community Welcome to these new cert-manager members (more info - cert-manager/cert-manager#6260): [@jsoref](https://github.com/jsoref) [@FlorianLiebhart](https://github.com/FlorianLiebhart) [@hawksight](https://github.com/hawksight) [@erikgb](https://github.com/erikgb) Thanks again to all open-source contributors with commits in this release, including: [@AcidLeroy](https://github.com/AcidLeroy) [@FlorianLiebhart](https://github.com/FlorianLiebhart) [@lucacome](https://github.com/lucacome) [@cypres](https://github.com/cypres) [@erikgb](https://github.com/erikgb) [@ubergesundheit](https://github.com/ubergesundheit) [@jkroepke](https://github.com/jkroepke) [@jsoref](https://github.com/jsoref) [@gdvalle](https://github.com/gdvalle) [@rouke-broersma](https://github.com/rouke-broersma) [@schrodit](https://github.com/schrodit) [@zhangzhiqiangcs](https://github.com/zhangzhiqiangcs) [@arukiidou](https://github.com/arukiidou) [@hawksight](https://github.com/hawksight) [@Richardds](https://github.com/Richardds) [@kahirokunn](https://github.com/kahirokunn) Thanks also to the following cert-manager maintainers for their contributions during this release: [@SgtCoDFish](https://github.com/SgtCoDFish) [@maelvls](https://github.com/maelvls) [@irbekrm](https://github.com/irbekrm) [@inteon](https://github.com/inteon) Equally thanks to everyone who provided feedback, helped users and raised issues on Github and Slack and joined our meetings! Special thanks to [@AcidLeroy](https://github.com/AcidLeroy) for adding "load options from a versioned config file" support for the cert-manager controller! This has been on our wishlist for a very long time. (see cert-manager/cert-manager#5337) Also, thanks a lot to [@FlorianLiebhart](https://github.com/FlorianLiebhart) for adding support for DNS over HTTPS for the ACME DNS self-check. This is very useful in case all traffic must be HTTP(S) trafic, eg. when using a HTTPS_PROXY. (see cert-manager/cert-manager#5003) Thanks also to the [CNCF](https://www.cncf.io/), which provides resources and support, and to the AWS open source team for being good community members and for their maintenance of the [PrivateCA Issuer](https://github.com/cert-manager/aws-privateca-issuer). In addition, massive thanks to [Venafi](https://www.venafi.com/) for contributing developer time and resources towards the continued maintenance of cert-manager projects. #### Changes since v1.12.0 ##### Feature - Add support for logging options to webhook config file. ([#6243](cert-manager/cert-manager#6243), [@inteon](https://github.com/inteon)) - Add view permissions to the well-known (Openshift) user-facing `cluster-reader` aggregated cluster role ([#6241](cert-manager/cert-manager#6241), [@erikgb](https://github.com/erikgb)) - Certificate Shim: distinguish dns names and ip address in certificate ([#6267](cert-manager/cert-manager#6267), [@zhangzhiqiangcs](https://github.com/zhangzhiqiangcs)) - Cmctl can now be imported by third parties. ([#6049](cert-manager/cert-manager#6049), [@SgtCoDFish](https://github.com/SgtCoDFish)) - Make `enableServiceLinks` configurable for all Deployments and `startupapicheck` Job in Helm chart. ([#6292](cert-manager/cert-manager#6292), [@ubergesundheit](https://github.com/ubergesundheit)) - Promoted the StableCertificateRequestName and SecretsFilteredCaching feature gates to Beta (enabled by default). ([#6298](cert-manager/cert-manager#6298), [@inteon](https://github.com/inteon)) - The cert-manager controller options are now configurable using a configuration file. ([#5337](cert-manager/cert-manager#5337), [@AcidLeroy](https://github.com/AcidLeroy)) - The pki CertificateTemplate functions now perform validation of the CSR blob, making sure we sign a Certificate that matches the IsCA and (Extended)KeyUsages that are defined in the CertificateRequest resource. ([#6199](cert-manager/cert-manager#6199), [@inteon](https://github.com/inteon)) - \[helm] Add prometheus.servicemonitor.endpointAdditionalProperties to define additional properties on a ServiceMonitor endpoint, e.g. relabelings ([#6110](cert-manager/cert-manager#6110), [@jkroepke](https://github.com/jkroepke)) ##### Design - DNS over HTTPS (DoH) is now possible for doing the self-checks during the ACME verification. The DNS check method to be used is controlled through the command line flag: `--dns01-recursive-nameservers-only=true` in combination with `--dns01-recursive-nameservers=https://<DoH-endpoint>` (e.g. `https://8.8.8.8/dns-query`). It keeps using DNS lookup as a default method. ([#5003](cert-manager/cert-manager#5003), [@FlorianLiebhart](https://github.com/FlorianLiebhart)) ##### Bug or Regression - Allow overriding default pdb .minAvailable with .maxUnavailable without setting .minAvailable to null ([#6087](cert-manager/cert-manager#6087), [@rouke-broersma](https://github.com/rouke-broersma)) - BUGFIX: `cmctl check api --wait 0` exited without output and exit code 1; we now make sure we perform the API check at least once and return with the correct error code ([#6109](cert-manager/cert-manager#6109), [@inteon](https://github.com/inteon)) - BUGFIX: the issuer and certificate-name annotations on a Secret were incorrectly updated when other fields are changed. ([#6147](cert-manager/cert-manager#6147), [@inteon](https://github.com/inteon)) - BUGFIX\[cainjector]: 1-character bug was causing invalid log messages and a memory leak ([#6232](cert-manager/cert-manager#6232), [@inteon](https://github.com/inteon)) - Fix CloudDNS issuers stuck in propagation check, when multiple instances are issuing for the same FQDN ([#6088](cert-manager/cert-manager#6088), [@cypres](https://github.com/cypres)) - Fix indentation of Webhook NetworkPolicy matchLabels in helm chart. ([#6220](cert-manager/cert-manager#6220), [@ubergesundheit](https://github.com/ubergesundheit)) - Fixed Cloudflare DNS01 challenge provider race condition when validating multiple domains ([#6191](cert-manager/cert-manager#6191), [@Richardds](https://github.com/Richardds)) - Fixes a bug where webhook was pulling in controller's feature gates. ⚠️ ⚠️ BREAKING ⚠️ ⚠️ : If you deploy cert-manager using helm and have `.featureGates` value set, the features defined there will no longer be passed to cert-manager webhook, only to cert-manager controller. Use `webhook.featureGates` field instead to define features to be enabled on webhook. **Potentially breaking**: If you were, for some reason, passing cert-manager controller's features to webhook's `--feature-gates` flag, this will now break (unless the webhook actually has a feature by that name). ([#6093](cert-manager/cert-manager#6093), [@irbekrm](https://github.com/irbekrm)) - Fixes an issue where cert-manager would incorrectly reject two IP addresses as being unequal when they should have compared equal. This would be most noticeable when using an IPv6 address which doesn't match how Go's `net.IP.String()` function would have printed that address. ([#6293](cert-manager/cert-manager#6293), [@SgtCoDFish](https://github.com/SgtCoDFish)) - We disabled the `enableServiceLinks` option for our ACME http solver pods, because the option caused the pod to be in a crash loop in a cluster with lot of services. ([#6143](cert-manager/cert-manager#6143), [@schrodit](https://github.com/schrodit)) - ⚠️ possibly breaking: Webhook validation of CertificateRequest resources is stricter now: all KeyUsages and ExtendedKeyUsages must be defined directly in the CertificateRequest resource, the encoded CSR can never contain more usages that defined there. ([#6182](cert-manager/cert-manager#6182), [@inteon](https://github.com/inteon)) ##### Other (Cleanup or Flake) - A subset of the klogs flags have been deprecated and will be removed in the future. ([#5879](cert-manager/cert-manager#5879), [@maelvls](https://github.com/maelvls)) - All service links in helm chart deployments have been disabled. ([#6144](cert-manager/cert-manager#6144), [@schrodit](https://github.com/schrodit)) - Cert-manager will now re-issue a certificate if the public key in the latest CertificateRequest resource linked to a Certificate resource does not match the public key of the key encoded in the Secret linked to that Certificate resource ([#6168](cert-manager/cert-manager#6168), [@inteon](https://github.com/inteon)) - Chore: When hostNetwork is enabled, dnsPolicy is now set to ClusterFirstWithHostNet. ([#6156](cert-manager/cert-manager#6156), [@kahirokunn](https://github.com/kahirokunn)) - Cleanup the controller configfile structure by introducing sub-structs. ([#6242](cert-manager/cert-manager#6242), [@inteon](https://github.com/inteon)) - Don't run API Priority and Fairness controller in webhook's extension apiserver ([#6085](cert-manager/cert-manager#6085), [@irbekrm](https://github.com/irbekrm)) - Helm: Add apache 2.0 license annotation ([#6225](cert-manager/cert-manager#6225), [@arukiidou](https://github.com/arukiidou)) - Make apis/acme/v1/ACMEIssuer.PreferredChain optional in JSON serialization. ([#6034](cert-manager/cert-manager#6034), [@gdvalle](https://github.com/gdvalle)) - The SecretPostIssuancePolicyChain now also makes sure that the `cert-manager.io/common-name`, `cert-manager.io/alt-names`, ... annotations on Secrets are kept at their correct value. ([#6176](cert-manager/cert-manager#6176), [@inteon](https://github.com/inteon)) - The cmctl logging has been improved and support for json logging has been added. ([#6247](cert-manager/cert-manager#6247), [@inteon](https://github.com/inteon)) - Updates Kubernetes libraries to `v0.27.2`. ([#6077](cert-manager/cert-manager#6077), [@lucacome](https://github.com/lucacome)) - Updates Kubernetes libraries to `v0.27.4`. ([#6227](cert-manager/cert-manager#6227), [@lucacome](https://github.com/lucacome)) - We now only check that the issuer name, kind and group annotations on a Secret match in case those annotations are set. ([#6152](cert-manager/cert-manager#6152), [@inteon](https://github.com/inteon)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.home/nrdufour/home-ops/pulls/84 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cert-manager](https://togithub.com/cert-manager/cert-manager) | minor | `v1.12.4` -> `v1.13.0` | --- ### Release Notes <details> <summary>cert-manager/cert-manager (cert-manager)</summary> ### [`v1.13.0`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.13.0) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.12.4...v1.13.0) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. This is the 1.13 release of cert-manager! #### Community Welcome to these new cert-manager members (more info - [cert-manager/cert-manager#6260): [@jsoref](https://togithub.com/jsoref) [@FlorianLiebhart](https://togithub.com/FlorianLiebhart) [@hawksight](https://togithub.com/hawksight) [@erikgb](https://togithub.com/erikgb) Thanks again to all open-source contributors with commits in this release, including: [@AcidLeroy](https://togithub.com/AcidLeroy) [@FlorianLiebhart](https://togithub.com/FlorianLiebhart) [@lucacome](https://togithub.com/lucacome) [@cypres](https://togithub.com/cypres) [@erikgb](https://togithub.com/erikgb) [@ubergesundheit](https://togithub.com/ubergesundheit) [@jkroepke](https://togithub.com/jkroepke) [@jsoref](https://togithub.com/jsoref) [@gdvalle](https://togithub.com/gdvalle) [@rouke-broersma](https://togithub.com/rouke-broersma) [@schrodit](https://togithub.com/schrodit) [@zhangzhiqiangcs](https://togithub.com/zhangzhiqiangcs) [@arukiidou](https://togithub.com/arukiidou) [@hawksight](https://togithub.com/hawksight) [@Richardds](https://togithub.com/Richardds) [@kahirokunn](https://togithub.com/kahirokunn) Thanks also to the following cert-manager maintainers for their contributions during this release: [@SgtCoDFish](https://togithub.com/SgtCoDFish) [@maelvls](https://togithub.com/maelvls) [@irbekrm](https://togithub.com/irbekrm) [@inteon](https://togithub.com/inteon) Equally thanks to everyone who provided feedback, helped users and raised issues on Github and Slack and joined our meetings! Special thanks to [@AcidLeroy](https://togithub.com/AcidLeroy) for adding "load options from a versioned config file" support for the cert-manager controller! This has been on our wishlist for a very long time. (see [cert-manager/cert-manager#5337) Also, thanks a lot to [@FlorianLiebhart](https://togithub.com/FlorianLiebhart) for adding support for DNS over HTTPS for the ACME DNS self-check. This is very useful in case all traffic must be HTTP(S) trafic, eg. when using a HTTPS_PROXY. (see [cert-manager/cert-manager#5003) Thanks also to the [CNCF](https://www.cncf.io/), which provides resources and support, and to the AWS open source team for being good community members and for their maintenance of the [PrivateCA Issuer](https://togithub.com/cert-manager/aws-privateca-issuer). In addition, massive thanks to [Venafi](https://www.venafi.com/) for contributing developer time and resources towards the continued maintenance of cert-manager projects. #### Changes since v1.12.0 ##### Feature - Add support for logging options to webhook config file. ([#6243](https://togithub.com/cert-manager/cert-manager/issues/6243), [@inteon](https://togithub.com/inteon)) - Add view permissions to the well-known (Openshift) user-facing `cluster-reader` aggregated cluster role ([#6241](https://togithub.com/cert-manager/cert-manager/issues/6241), [@erikgb](https://togithub.com/erikgb)) - Certificate Shim: distinguish dns names and ip address in certificate ([#6267](https://togithub.com/cert-manager/cert-manager/issues/6267), [@zhangzhiqiangcs](https://togithub.com/zhangzhiqiangcs)) - Cmctl can now be imported by third parties. ([#6049](https://togithub.com/cert-manager/cert-manager/issues/6049), [@SgtCoDFish](https://togithub.com/SgtCoDFish)) - Make `enableServiceLinks` configurable for all Deployments and `startupapicheck` Job in Helm chart. ([#6292](https://togithub.com/cert-manager/cert-manager/issues/6292), [@ubergesundheit](https://togithub.com/ubergesundheit)) - Promoted the StableCertificateRequestName and SecretsFilteredCaching feature gates to Beta (enabled by default). ([#6298](https://togithub.com/cert-manager/cert-manager/issues/6298), [@inteon](https://togithub.com/inteon)) - The cert-manager controller options are now configurable using a configuration file. ([#5337](https://togithub.com/cert-manager/cert-manager/issues/5337), [@AcidLeroy](https://togithub.com/AcidLeroy)) - The pki CertificateTemplate functions now perform validation of the CSR blob, making sure we sign a Certificate that matches the IsCA and (Extended)KeyUsages that are defined in the CertificateRequest resource. ([#6199](https://togithub.com/cert-manager/cert-manager/issues/6199), [@inteon](https://togithub.com/inteon)) - \[helm] Add prometheus.servicemonitor.endpointAdditionalProperties to define additional properties on a ServiceMonitor endpoint, e.g. relabelings ([#6110](https://togithub.com/cert-manager/cert-manager/issues/6110), [@jkroepke](https://togithub.com/jkroepke)) ##### Design - DNS over HTTPS (DoH) is now possible for doing the self-checks during the ACME verification. The DNS check method to be used is controlled through the command line flag: `--dns01-recursive-nameservers-only=true` in combination with `--dns01-recursive-nameservers=https://<DoH-endpoint>` (e.g. `https://8.8.8.8/dns-query`). It keeps using DNS lookup as a default method. ([#5003](https://togithub.com/cert-manager/cert-manager/issues/5003), [@FlorianLiebhart](https://togithub.com/FlorianLiebhart)) ##### Bug or Regression - Allow overriding default pdb .minAvailable with .maxUnavailable without setting .minAvailable to null ([#6087](https://togithub.com/cert-manager/cert-manager/issues/6087), [@rouke-broersma](https://togithub.com/rouke-broersma)) - BUGFIX: `cmctl check api --wait 0` exited without output and exit code 1; we now make sure we perform the API check at least once and return with the correct error code ([#6109](https://togithub.com/cert-manager/cert-manager/issues/6109), [@inteon](https://togithub.com/inteon)) - BUGFIX: the issuer and certificate-name annotations on a Secret were incorrectly updated when other fields are changed. ([#6147](https://togithub.com/cert-manager/cert-manager/issues/6147), [@inteon](https://togithub.com/inteon)) - BUGFIX\[cainjector]: 1-character bug was causing invalid log messages and a memory leak ([#6232](https://togithub.com/cert-manager/cert-manager/issues/6232), [@inteon](https://togithub.com/inteon)) - Fix CloudDNS issuers stuck in propagation check, when multiple instances are issuing for the same FQDN ([#6088](https://togithub.com/cert-manager/cert-manager/issues/6088), [@cypres](https://togithub.com/cypres)) - Fix indentation of Webhook NetworkPolicy matchLabels in helm chart. ([#6220](https://togithub.com/cert-manager/cert-manager/issues/6220), [@ubergesundheit](https://togithub.com/ubergesundheit)) - Fixed Cloudflare DNS01 challenge provider race condition when validating multiple domains ([#6191](https://togithub.com/cert-manager/cert-manager/issues/6191), [@Richardds](https://togithub.com/Richardds)) - Fixes a bug where webhook was pulling in controller's feature gates. ⚠️ ⚠️ BREAKING ⚠️ ⚠️ : If you deploy cert-manager using helm and have `.featureGates` value set, the features defined there will no longer be passed to cert-manager webhook, only to cert-manager controller. Use `webhook.featureGates` field instead to define features to be enabled on webhook. **Potentially breaking**: If you were, for some reason, passing cert-manager controller's features to webhook's `--feature-gates` flag, this will now break (unless the webhook actually has a feature by that name). ([#6093](https://togithub.com/cert-manager/cert-manager/issues/6093), [@irbekrm](https://togithub.com/irbekrm)) - Fixes an issue where cert-manager would incorrectly reject two IP addresses as being unequal when they should have compared equal. This would be most noticeable when using an IPv6 address which doesn't match how Go's `net.IP.String()` function would have printed that address. ([#6293](https://togithub.com/cert-manager/cert-manager/issues/6293), [@SgtCoDFish](https://togithub.com/SgtCoDFish)) - We disabled the `enableServiceLinks` option for our ACME http solver pods, because the option caused the pod to be in a crash loop in a cluster with lot of services. ([#6143](https://togithub.com/cert-manager/cert-manager/issues/6143), [@schrodit](https://togithub.com/schrodit)) - ⚠️ possibly breaking: Webhook validation of CertificateRequest resources is stricter now: all KeyUsages and ExtendedKeyUsages must be defined directly in the CertificateRequest resource, the encoded CSR can never contain more usages that defined there. ([#6182](https://togithub.com/cert-manager/cert-manager/issues/6182), [@inteon](https://togithub.com/inteon)) ##### Other (Cleanup or Flake) - A subset of the klogs flags have been deprecated and will be removed in the future. ([#5879](https://togithub.com/cert-manager/cert-manager/issues/5879), [@maelvls](https://togithub.com/maelvls)) - All service links in helm chart deployments have been disabled. ([#6144](https://togithub.com/cert-manager/cert-manager/issues/6144), [@schrodit](https://togithub.com/schrodit)) - Cert-manager will now re-issue a certificate if the public key in the latest CertificateRequest resource linked to a Certificate resource does not match the public key of the key encoded in the Secret linked to that Certificate resource ([#6168](https://togithub.com/cert-manager/cert-manager/issues/6168), [@inteon](https://togithub.com/inteon)) - Chore: When hostNetwork is enabled, dnsPolicy is now set to ClusterFirstWithHostNet. ([#6156](https://togithub.com/cert-manager/cert-manager/issues/6156), [@kahirokunn](https://togithub.com/kahirokunn)) - Cleanup the controller configfile structure by introducing sub-structs. ([#6242](https://togithub.com/cert-manager/cert-manager/issues/6242), [@inteon](https://togithub.com/inteon)) - Don't run API Priority and Fairness controller in webhook's extension apiserver ([#6085](https://togithub.com/cert-manager/cert-manager/issues/6085), [@irbekrm](https://togithub.com/irbekrm)) - Helm: Add apache 2.0 license annotation ([#6225](https://togithub.com/cert-manager/cert-manager/issues/6225), [@arukiidou](https://togithub.com/arukiidou)) - Make apis/acme/v1/ACMEIssuer.PreferredChain optional in JSON serialization. ([#6034](https://togithub.com/cert-manager/cert-manager/issues/6034), [@gdvalle](https://togithub.com/gdvalle)) - The SecretPostIssuancePolicyChain now also makes sure that the `cert-manager.io/common-name`, `cert-manager.io/alt-names`, ... annotations on Secrets are kept at their correct value. ([#6176](https://togithub.com/cert-manager/cert-manager/issues/6176), [@inteon](https://togithub.com/inteon)) - The cmctl logging has been improved and support for json logging has been added. ([#6247](https://togithub.com/cert-manager/cert-manager/issues/6247), [@inteon](https://togithub.com/inteon)) - Updates Kubernetes libraries to `v0.27.2`. ([#6077](https://togithub.com/cert-manager/cert-manager/issues/6077), [@lucacome](https://togithub.com/lucacome)) - Updates Kubernetes libraries to `v0.27.4`. ([#6227](https://togithub.com/cert-manager/cert-manager/issues/6227), [@lucacome](https://togithub.com/lucacome)) - We now only check that the issuer name, kind and group annotations on a Secret match in case those annotations are set. ([#6152](https://togithub.com/cert-manager/cert-manager/issues/6152), [@inteon](https://togithub.com/inteon)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cert-manager](https://togithub.com/cert-manager/cert-manager) | minor | `v1.12.4` -> `v1.13.0` | --- ### Release Notes <details> <summary>cert-manager/cert-manager (cert-manager)</summary> ### [`v1.13.0`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.13.0) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.12.4...v1.13.0) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. This is the 1.13 release of cert-manager! cert-manager 1.13 brings support for DNS over HTTPS, support for loading options from a versioned config file for the cert-manager controller, and more. This release also includes the promotion of the StableCertificateRequestName and SecretsFilteredCaching feature gates to Beta. #### Breaking Changes (You MUST read this before you upgrade!) 1. **BREAKING** : If you deploy cert-manager using helm and have `.featureGates` value set, the features defined there will no longer be passed to cert-manager webhook, only to cert-manager controller. Use `webhook.featureGates` field instead to define features to be enabled on webhook. ([#6093](https://togithub.com/cert-manager/cert-manager/issues/6093), [@irbekrm](https://togithub.com/irbekrm)) 2. **Potentially breaking**: If you were, for some reason, passing cert-manager controller's features to webhook's `--feature-gates` flag, this will now break (unless the webhook actually has a feature by that name). ([#6093](https://togithub.com/cert-manager/cert-manager/issues/6093), [@irbekrm](https://togithub.com/irbekrm)) 3. **Potentially breaking**: Webhook validation of CertificateRequest resources is stricter now: all KeyUsages and ExtendedKeyUsages must be defined directly in the CertificateRequest resource, the encoded CSR can never contain more usages that defined there. ([#6182](https://togithub.com/cert-manager/cert-manager/issues/6182), [@inteon](https://togithub.com/inteon)) #### Community Welcome to these new cert-manager members (more info - [cert-manager/cert-manager#6260): [@jsoref](https://togithub.com/jsoref) [@FlorianLiebhart](https://togithub.com/FlorianLiebhart) [@hawksight](https://togithub.com/hawksight) [@erikgb](https://togithub.com/erikgb) Thanks again to all open-source contributors with commits in this release, including: [@AcidLeroy](https://togithub.com/AcidLeroy) [@FlorianLiebhart](https://togithub.com/FlorianLiebhart) [@lucacome](https://togithub.com/lucacome) [@cypres](https://togithub.com/cypres) [@erikgb](https://togithub.com/erikgb) [@ubergesundheit](https://togithub.com/ubergesundheit) [@jkroepke](https://togithub.com/jkroepke) [@jsoref](https://togithub.com/jsoref) [@gdvalle](https://togithub.com/gdvalle) [@rouke-broersma](https://togithub.com/rouke-broersma) [@schrodit](https://togithub.com/schrodit) [@zhangzhiqiangcs](https://togithub.com/zhangzhiqiangcs) [@arukiidou](https://togithub.com/arukiidou) [@hawksight](https://togithub.com/hawksight) [@Richardds](https://togithub.com/Richardds) [@kahirokunn](https://togithub.com/kahirokunn) Thanks also to the following cert-manager maintainers for their contributions during this release: [@SgtCoDFish](https://togithub.com/SgtCoDFish) [@maelvls](https://togithub.com/maelvls) [@irbekrm](https://togithub.com/irbekrm) [@inteon](https://togithub.com/inteon) Equally thanks to everyone who provided feedback, helped users and raised issues on Github and Slack and joined our meetings! Special thanks to [@AcidLeroy](https://togithub.com/AcidLeroy) for adding "load options from a versioned config file" support for the cert-manager controller! This has been on our wishlist for a very long time. (see [cert-manager/cert-manager#5337) Also, thanks a lot to [@FlorianLiebhart](https://togithub.com/FlorianLiebhart) for adding support for DNS over HTTPS for the ACME DNS self-check. This is very useful in case all traffic must be HTTP(S) trafic, eg. when using a HTTPS_PROXY. (see [cert-manager/cert-manager#5003) Thanks also to the [CNCF](https://www.cncf.io/), which provides resources and support, and to the AWS open source team for being good community members and for their maintenance of the [PrivateCA Issuer](https://togithub.com/cert-manager/aws-privateca-issuer). In addition, massive thanks to [Venafi](https://www.venafi.com/) for contributing developer time and resources towards the continued maintenance of cert-manager projects. #### Changes since v1.12.0 ##### Feature - Add support for logging options to webhook config file. ([#6243](https://togithub.com/cert-manager/cert-manager/issues/6243), [@inteon](https://togithub.com/inteon)) - Add view permissions to the well-known (Openshift) user-facing `cluster-reader` aggregated cluster role ([#6241](https://togithub.com/cert-manager/cert-manager/issues/6241), [@erikgb](https://togithub.com/erikgb)) - Certificate Shim: distinguish dns names and ip address in certificate ([#6267](https://togithub.com/cert-manager/cert-manager/issues/6267), [@zhangzhiqiangcs](https://togithub.com/zhangzhiqiangcs)) - Cmctl can now be imported by third parties. ([#6049](https://togithub.com/cert-manager/cert-manager/issues/6049), [@SgtCoDFish](https://togithub.com/SgtCoDFish)) - Make `enableServiceLinks` configurable for all Deployments and `startupapicheck` Job in Helm chart. ([#6292](https://togithub.com/cert-manager/cert-manager/issues/6292), [@ubergesundheit](https://togithub.com/ubergesundheit)) - Promoted the StableCertificateRequestName and SecretsFilteredCaching feature gates to Beta (enabled by default). ([#6298](https://togithub.com/cert-manager/cert-manager/issues/6298), [@inteon](https://togithub.com/inteon)) - The cert-manager controller options are now configurable using a configuration file. ([#5337](https://togithub.com/cert-manager/cert-manager/issues/5337), [@AcidLeroy](https://togithub.com/AcidLeroy)) - The pki CertificateTemplate functions now perform validation of the CSR blob, making sure we sign a Certificate that matches the IsCA and (Extended)KeyUsages that are defined in the CertificateRequest resource. ([#6199](https://togithub.com/cert-manager/cert-manager/issues/6199), [@inteon](https://togithub.com/inteon)) - \[helm] Add prometheus.servicemonitor.endpointAdditionalProperties to define additional properties on a ServiceMonitor endpoint, e.g. relabelings ([#6110](https://togithub.com/cert-manager/cert-manager/issues/6110), [@jkroepke](https://togithub.com/jkroepke)) ##### Design - DNS over HTTPS (DoH) is now possible for doing the self-checks during the ACME verification. The DNS check method to be used is controlled through the command line flag: `--dns01-recursive-nameservers-only=true` in combination with `--dns01-recursive-nameservers=https://<DoH-endpoint>` (e.g. `https://8.8.8.8/dns-query`). It keeps using DNS lookup as a default method. ([#5003](https://togithub.com/cert-manager/cert-manager/issues/5003), [@FlorianLiebhart](https://togithub.com/FlorianLiebhart)) ##### Bug or Regression - Allow overriding default pdb .minAvailable with .maxUnavailable without setting .minAvailable to null ([#6087](https://togithub.com/cert-manager/cert-manager/issues/6087), [@rouke-broersma](https://togithub.com/rouke-broersma)) - BUGFIX: `cmctl check api --wait 0` exited without output and exit code 1; we now make sure we perform the API check at least once and return with the correct error code ([#6109](https://togithub.com/cert-manager/cert-manager/issues/6109), [@inteon](https://togithub.com/inteon)) - BUGFIX: the issuer and certificate-name annotations on a Secret were incorrectly updated when other fields are changed. ([#6147](https://togithub.com/cert-manager/cert-manager/issues/6147), [@inteon](https://togithub.com/inteon)) - BUGFIX\[cainjector]: 1-character bug was causing invalid log messages and a memory leak ([#6232](https://togithub.com/cert-manager/cert-manager/issues/6232), [@inteon](https://togithub.com/inteon)) - Fix CloudDNS issuers stuck in propagation check, when multiple instances are issuing for the same FQDN ([#6088](https://togithub.com/cert-manager/cert-manager/issues/6088), [@cypres](https://togithub.com/cypres)) - Fix indentation of Webhook NetworkPolicy matchLabels in helm chart. ([#6220](https://togithub.com/cert-manager/cert-manager/issues/6220), [@ubergesundheit](https://togithub.com/ubergesundheit)) - Fixed Cloudflare DNS01 challenge provider race condition when validating multiple domains ([#6191](https://togithub.com/cert-manager/cert-manager/issues/6191), [@Richardds](https://togithub.com/Richardds)) - Fixes a bug where webhook was pulling in controller's feature gates. **⚠️ ⚠️ BREAKING ⚠️ ⚠️** : If you deploy cert-manager using helm and have `.featureGates` value set, the features defined there will no longer be passed to cert-manager webhook, only to cert-manager controller. Use `webhook.featureGates` field instead to define features to be enabled on webhook. **⚠️Potentially breaking**: If you were, for some reason, passing cert-manager controller's features to webhook's `--feature-gates` flag, this will now break (unless the webhook actually has a feature by that name). ([#6093](https://togithub.com/cert-manager/cert-manager/issues/6093), [@irbekrm](https://togithub.com/irbekrm)) - Fixes an issue where cert-manager would incorrectly reject two IP addresses as being unequal when they should have compared equal. This would be most noticeable when using an IPv6 address which doesn't match how Go's `net.IP.String()` function would have printed that address. ([#6293](https://togithub.com/cert-manager/cert-manager/issues/6293), [@SgtCoDFish](https://togithub.com/SgtCoDFish)) - We disabled the `enableServiceLinks` option for our ACME http solver pods, because the option caused the pod to be in a crash loop in a cluster with lot of services. ([#6143](https://togithub.com/cert-manager/cert-manager/issues/6143), [@schrodit](https://togithub.com/schrodit)) - **⚠️Potentially breaking**: Webhook validation of CertificateRequest resources is stricter now: all KeyUsages and ExtendedKeyUsages must be defined directly in the CertificateRequest resource, the encoded CSR can never contain more usages that defined there. ([#6182](https://togithub.com/cert-manager/cert-manager/issues/6182), [@inteon](https://togithub.com/inteon)) ##### Other (Cleanup or Flake) - A subset of the klogs flags have been deprecated and will be removed in the future. ([#5879](https://togithub.com/cert-manager/cert-manager/issues/5879), [@maelvls](https://togithub.com/maelvls)) - All service links in helm chart deployments have been disabled. ([#6144](https://togithub.com/cert-manager/cert-manager/issues/6144), [@schrodit](https://togithub.com/schrodit)) - Cert-manager will now re-issue a certificate if the public key in the latest CertificateRequest resource linked to a Certificate resource does not match the public key of the key encoded in the Secret linked to that Certificate resource ([#6168](https://togithub.com/cert-manager/cert-manager/issues/6168), [@inteon](https://togithub.com/inteon)) - Chore: When hostNetwork is enabled, dnsPolicy is now set to ClusterFirstWithHostNet. ([#6156](https://togithub.com/cert-manager/cert-manager/issues/6156), [@kahirokunn](https://togithub.com/kahirokunn)) - Cleanup the controller configfile structure by introducing sub-structs. ([#6242](https://togithub.com/cert-manager/cert-manager/issues/6242), [@inteon](https://togithub.com/inteon)) - Don't run API Priority and Fairness controller in webhook's extension apiserver ([#6085](https://togithub.com/cert-manager/cert-manager/issues/6085), [@irbekrm](https://togithub.com/irbekrm)) - Helm: Add apache 2.0 license annotation ([#6225](https://togithub.com/cert-manager/cert-manager/issues/6225), [@arukiidou](https://togithub.com/arukiidou)) - Make apis/acme/v1/ACMEIssuer.PreferredChain optional in JSON serialization. ([#6034](https://togithub.com/cert-manager/cert-manager/issues/6034), [@gdvalle](https://togithub.com/gdvalle)) - The SecretPostIssuancePolicyChain now also makes sure that the `cert-manager.io/common-name`, `cert-manager.io/alt-names`, ... annotations on Secrets are kept at their correct value. ([#6176](https://togithub.com/cert-manager/cert-manager/issues/6176), [@inteon](https://togithub.com/inteon)) - The cmctl logging has been improved and support for json logging has been added. ([#6247](https://togithub.com/cert-manager/cert-manager/issues/6247), [@inteon](https://togithub.com/inteon)) - Updates Kubernetes libraries to `v0.27.2`. ([#6077](https://togithub.com/cert-manager/cert-manager/issues/6077), [@lucacome](https://togithub.com/lucacome)) - Updates Kubernetes libraries to `v0.27.4`. ([#6227](https://togithub.com/cert-manager/cert-manager/issues/6227), [@lucacome](https://togithub.com/lucacome)) - We now only check that the issuer name, kind and group annotations on a Secret match in case those annotations are set. ([#6152](https://togithub.com/cert-manager/cert-manager/issues/6152), [@inteon](https://togithub.com/inteon)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: repo-jeeves <106431701+repo-jeeves[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cert-manager](https://togithub.com/cert-manager/cert-manager) | minor | `v1.12.3` -> `v1.13.1` | | [clickhouse](https://truecharts.org/charts/dependency/clickhouse) ([source](https://togithub.com/truecharts/charts)) | patch | `7.0.1` -> `7.0.8` | | [common](https://togithub.com/truecharts/apps/tree/master/charts/common) ([source](https://togithub.com/truecharts/library-charts)) | patch | `14.0.1` -> `14.0.6` | | [common](https://togithub.com/truecharts/apps/tree/master/charts/common) ([source](https://togithub.com/truecharts/library-charts)) | patch | `14.0.3` -> `14.0.6` | | [common](https://togithub.com/truecharts/apps/tree/master/charts/common) ([source](https://togithub.com/truecharts/library-charts)) | patch | `14.0.4` -> `14.0.6` | | [common](https://togithub.com/truecharts/apps/tree/master/charts/common) ([source](https://togithub.com/truecharts/library-charts)) | patch | `13.2.1` -> `13.2.2` | | [common](https://togithub.com/truecharts/apps/tree/master/charts/common) ([source](https://togithub.com/truecharts/library-charts)) | patch | `14.0.2` -> `14.0.6` | | [redis](https://truecharts.org/charts/dependency/redis) ([source](https://togithub.com/truecharts/charts)) | patch | `8.0.0` -> `8.0.27` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>cert-manager/cert-manager (cert-manager)</summary> ### [`v1.13.1`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.13.1) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.13.0...v1.13.1) v1.13.1 contains a bugfix for a name collision bug in the StableCertificateRequestName feature that was enabled by default in v1.13.0. ##### ⚠️ READ https://github.com/cert-manager/cert-manager/releases/tag/v1.13.0 before you upgrade from a < v1.13 version! #### Changes since v1.13.0 ##### Bug or Regression - BUGFIX: fix CertificateRequest name collision bug in StableCertificateRequestName feature. ([#6358](https://togithub.com/cert-manager/cert-manager/issues/6358), [@jetstack-bot](https://togithub.com/jetstack-bot)) ##### Other (Cleanup or Flake) - Upgrade `github.com/emicklei/go-restful/v3` to `v3.11.0` because `v3.10.2` is labeled as "DO NOT USE". ([#6368](https://togithub.com/cert-manager/cert-manager/issues/6368), [@inteon](https://togithub.com/inteon)) - Upgrade Go from 1.20.7 to 1.20.8. ([#6370](https://togithub.com/cert-manager/cert-manager/issues/6370), [@jetstack-bot](https://togithub.com/jetstack-bot)) ### [`v1.13.0`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.13.0) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.12.5...v1.13.0) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. This is the 1.13 release of cert-manager! cert-manager 1.13 brings support for DNS over HTTPS, support for loading options from a versioned config file for the cert-manager controller, and more. This release also includes the promotion of the StableCertificateRequestName and SecretsFilteredCaching feature gates to Beta. #### Known issues The `StableCertificateRequestName` that was promoted to Beta contains a "name collision" bug: [cert-manager/cert-manager#6342 This will be fixed in v1.13.1. #### Breaking Changes (You MUST read this before you upgrade!) 1. **BREAKING** : If you deploy cert-manager using helm and have `.featureGates` value set, the features defined there will no longer be passed to cert-manager webhook, only to cert-manager controller. Use `webhook.featureGates` field instead to define features to be enabled on webhook. ([#6093](https://togithub.com/cert-manager/cert-manager/issues/6093), [@irbekrm](https://togithub.com/irbekrm)) 2. **Potentially breaking**: If you were, for some reason, passing cert-manager controller's features to webhook's `--feature-gates` flag, this will now break (unless the webhook actually has a feature by that name). ([#6093](https://togithub.com/cert-manager/cert-manager/issues/6093), [@irbekrm](https://togithub.com/irbekrm)) 3. **Potentially breaking**: Webhook validation of CertificateRequest resources is stricter now: all KeyUsages and ExtendedKeyUsages must be defined directly in the CertificateRequest resource, the encoded CSR can never contain more usages that defined there. ([#6182](https://togithub.com/cert-manager/cert-manager/issues/6182), [@inteon](https://togithub.com/inteon)) #### Community Welcome to these new cert-manager members (more info - [cert-manager/cert-manager#6260): [@jsoref](https://togithub.com/jsoref) [@FlorianLiebhart](https://togithub.com/FlorianLiebhart) [@hawksight](https://togithub.com/hawksight) [@erikgb](https://togithub.com/erikgb) Thanks again to all open-source contributors with commits in this release, including: [@AcidLeroy](https://togithub.com/AcidLeroy) [@FlorianLiebhart](https://togithub.com/FlorianLiebhart) [@lucacome](https://togithub.com/lucacome) [@cypres](https://togithub.com/cypres) [@erikgb](https://togithub.com/erikgb) [@ubergesundheit](https://togithub.com/ubergesundheit) [@jkroepke](https://togithub.com/jkroepke) [@jsoref](https://togithub.com/jsoref) [@gdvalle](https://togithub.com/gdvalle) [@rouke-broersma](https://togithub.com/rouke-broersma) [@schrodit](https://togithub.com/schrodit) [@zhangzhiqiangcs](https://togithub.com/zhangzhiqiangcs) [@arukiidou](https://togithub.com/arukiidou) [@hawksight](https://togithub.com/hawksight) [@Richardds](https://togithub.com/Richardds) [@kahirokunn](https://togithub.com/kahirokunn) Thanks also to the following cert-manager maintainers for their contributions during this release: [@SgtCoDFish](https://togithub.com/SgtCoDFish) [@maelvls](https://togithub.com/maelvls) [@irbekrm](https://togithub.com/irbekrm) [@inteon](https://togithub.com/inteon) Equally thanks to everyone who provided feedback, helped users and raised issues on Github and Slack and joined our meetings! Special thanks to [@AcidLeroy](https://togithub.com/AcidLeroy) for adding "load options from a versioned config file" support for the cert-manager controller! This has been on our wishlist for a very long time. (see [cert-manager/cert-manager#5337) Also, thanks a lot to [@FlorianLiebhart](https://togithub.com/FlorianLiebhart) for adding support for DNS over HTTPS for the ACME DNS self-check. This is very useful in case all traffic must be HTTP(S) trafic, eg. when using a HTTPS_PROXY. (see [cert-manager/cert-manager#5003) Thanks also to the [CNCF](https://www.cncf.io/), which provides resources and support, and to the AWS open source team for being good community members and for their maintenance of the [PrivateCA Issuer](https://togithub.com/cert-manager/aws-privateca-issuer). In addition, massive thanks to [Venafi](https://www.venafi.com/) for contributing developer time and resources towards the continued maintenance of cert-manager projects. #### Changes since v1.12.0 ##### Feature - Add support for logging options to webhook config file. ([#6243](https://togithub.com/cert-manager/cert-manager/issues/6243), [@inteon](https://togithub.com/inteon)) - Add view permissions to the well-known (Openshift) user-facing `cluster-reader` aggregated cluster role ([#6241](https://togithub.com/cert-manager/cert-manager/issues/6241), [@erikgb](https://togithub.com/erikgb)) - Certificate Shim: distinguish dns names and ip address in certificate ([#6267](https://togithub.com/cert-manager/cert-manager/issues/6267), [@zhangzhiqiangcs](https://togithub.com/zhangzhiqiangcs)) - Cmctl can now be imported by third parties. ([#6049](https://togithub.com/cert-manager/cert-manager/issues/6049), [@SgtCoDFish](https://togithub.com/SgtCoDFish)) - Make `enableServiceLinks` configurable for all Deployments and `startupapicheck` Job in Helm chart. ([#6292](https://togithub.com/cert-manager/cert-manager/issues/6292), [@ubergesundheit](https://togithub.com/ubergesundheit)) - Promoted the StableCertificateRequestName and SecretsFilteredCaching feature gates to Beta (enabled by default). ([#6298](https://togithub.com/cert-manager/cert-manager/issues/6298), [@inteon](https://togithub.com/inteon)) - The cert-manager controller options are now configurable using a configuration file. ([#5337](https://togithub.com/cert-manager/cert-manager/issues/5337), [@AcidLeroy](https://togithub.com/AcidLeroy)) - The pki CertificateTemplate functions now perform validation of the CSR blob, making sure we sign a Certificate that matches the IsCA and (Extended)KeyUsages that are defined in the CertificateRequest resource. ([#6199](https://togithub.com/cert-manager/cert-manager/issues/6199), [@inteon](https://togithub.com/inteon)) - \[helm] Add prometheus.servicemonitor.endpointAdditionalProperties to define additional properties on a ServiceMonitor endpoint, e.g. relabelings ([#6110](https://togithub.com/cert-manager/cert-manager/issues/6110), [@jkroepke](https://togithub.com/jkroepke)) ##### Design - DNS over HTTPS (DoH) is now possible for doing the self-checks during the ACME verification. The DNS check method to be used is controlled through the command line flag: `--dns01-recursive-nameservers-only=true` in combination with `--dns01-recursive-nameservers=https://<DoH-endpoint>` (e.g. `https://8.8.8.8/dns-query`). It keeps using DNS lookup as a default method. ([#5003](https://togithub.com/cert-manager/cert-manager/issues/5003), [@FlorianLiebhart](https://togithub.com/FlorianLiebhart)) ##### Bug or Regression - Allow overriding default pdb .minAvailable with .maxUnavailable without setting .minAvailable to null ([#6087](https://togithub.com/cert-manager/cert-manager/issues/6087), [@rouke-broersma](https://togithub.com/rouke-broersma)) - BUGFIX: `cmctl check api --wait 0` exited without output and exit code 1; we now make sure we perform the API check at least once and return with the correct error code ([#6109](https://togithub.com/cert-manager/cert-manager/issues/6109), [@inteon](https://togithub.com/inteon)) - BUGFIX: the issuer and certificate-name annotations on a Secret were incorrectly updated when other fields are changed. ([#6147](https://togithub.com/cert-manager/cert-manager/issues/6147), [@inteon](https://togithub.com/inteon)) - BUGFIX\[cainjector]: 1-character bug was causing invalid log messages and a memory leak ([#6232](https://togithub.com/cert-manager/cert-manager/issues/6232), [@inteon](https://togithub.com/inteon)) - Fix CloudDNS issuers stuck in propagation check, when multiple instances are issuing for the same FQDN ([#6088](https://togithub.com/cert-manager/cert-manager/issues/6088), [@cypres](https://togithub.com/cypres)) - Fix indentation of Webhook NetworkPolicy matchLabels in helm chart. ([#6220](https://togithub.com/cert-manager/cert-manager/issues/6220), [@ubergesundheit](https://togithub.com/ubergesundheit)) - Fixed Cloudflare DNS01 challenge provider race condition when validating multiple domains ([#6191](https://togithub.com/cert-manager/cert-manager/issues/6191), [@Richardds](https://togithub.com/Richardds)) - Fixes a bug where webhook was pulling in controller's feature gates. **⚠️ ⚠️ BREAKING ⚠️ ⚠️** : If you deploy cert-manager using helm and have `.featureGates` value set, the features defined there will no longer be passed to cert-manager webhook, only to cert-manager controller. Use `webhook.featureGates` field instead to define features to be enabled on webhook. **⚠️Potentially breaking**: If you were, for some reason, passing cert-manager controller's features to webhook's `--feature-gates` flag, this will now break (unless the webhook actually has a feature by that name). ([#6093](https://togithub.com/cert-manager/cert-manager/issues/6093), [@irbekrm](https://togithub.com/irbekrm)) - Fixes an issue where cert-manager would incorrectly reject two IP addresses as being unequal when they should have compared equal. This would be most noticeable when using an IPv6 address which doesn't match how Go's `net.IP.String()` function would have printed that address. ([#6293](https://togithub.com/cert-manager/cert-manager/issues/6293), [@SgtCoDFish](https://togithub.com/SgtCoDFish)) - We disabled the `enableServiceLinks` option for our ACME http solver pods, because the option caused the pod to be in a crash loop in a cluster with lot of services. ([#6143](https://togithub.com/cert-manager/cert-manager/issues/6143), [@schrodit](https://togithub.com/schrodit)) - **⚠️Potentially breaking**: Webhook validation of CertificateRequest resources is stricter now: all KeyUsages and ExtendedKeyUsages must be defined directly in the CertificateRequest resource, the encoded CSR can never contain more usages that defined there. ([#6182](https://togithub.com/cert-manager/cert-manager/issues/6182), [@inteon](https://togithub.com/inteon)) ##### Other (Cleanup or Flake) - A subset of the klogs flags have been deprecated and will be removed in the future. ([#5879](https://togithub.com/cert-manager/cert-manager/issues/5879), [@maelvls](https://togithub.com/maelvls)) - All service links in helm chart deployments have been disabled. ([#6144](https://togithub.com/cert-manager/cert-manager/issues/6144), [@schrodit](https://togithub.com/schrodit)) - Cert-manager will now re-issue a certificate if the public key in the latest CertificateRequest resource linked to a Certificate resource does not match the public key of the key encoded in the Secret linked to that Certificate resource ([#6168](https://togithub.com/cert-manager/cert-manager/issues/6168), [@inteon](https://togithub.com/inteon)) - Chore: When hostNetwork is enabled, dnsPolicy is now set to ClusterFirstWithHostNet. ([#6156](https://togithub.com/cert-manager/cert-manager/issues/6156), [@kahirokunn](https://togithub.com/kahirokunn)) - Cleanup the controller configfile structure by introducing sub-structs. ([#6242](https://togithub.com/cert-manager/cert-manager/issues/6242), [@inteon](https://togithub.com/inteon)) - Don't run API Priority and Fairness controller in webhook's extension apiserver ([#6085](https://togithub.com/cert-manager/cert-manager/issues/6085), [@irbekrm](https://togithub.com/irbekrm)) - Helm: Add apache 2.0 license annotation ([#6225](https://togithub.com/cert-manager/cert-manager/issues/6225), [@arukiidou](https://togithub.com/arukiidou)) - Make apis/acme/v1/ACMEIssuer.PreferredChain optional in JSON serialization. ([#6034](https://togithub.com/cert-manager/cert-manager/issues/6034), [@gdvalle](https://togithub.com/gdvalle)) - The SecretPostIssuancePolicyChain now also makes sure that the `cert-manager.io/common-name`, `cert-manager.io/alt-names`, ... annotations on Secrets are kept at their correct value. ([#6176](https://togithub.com/cert-manager/cert-manager/issues/6176), [@inteon](https://togithub.com/inteon)) - The cmctl logging has been improved and support for json logging has been added. ([#6247](https://togithub.com/cert-manager/cert-manager/issues/6247), [@inteon](https://togithub.com/inteon)) - Updates Kubernetes libraries to `v0.27.2`. ([#6077](https://togithub.com/cert-manager/cert-manager/issues/6077), [@lucacome](https://togithub.com/lucacome)) - Updates Kubernetes libraries to `v0.27.4`. ([#6227](https://togithub.com/cert-manager/cert-manager/issues/6227), [@lucacome](https://togithub.com/lucacome)) - We now only check that the issuer name, kind and group annotations on a Secret match in case those annotations are set. ([#6152](https://togithub.com/cert-manager/cert-manager/issues/6152), [@inteon](https://togithub.com/inteon)) ### [`v1.12.5`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.12.5) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.12.4...v1.12.5) v1.12.5 contains a backport for a name collision bug that was found in v1.13.0 #### Changes since v1.12.4 ##### Bug or Regression - BUGFIX: fix CertificateRequest name collision bug in StableCertificateRequestName feature. ([#6359](https://togithub.com/cert-manager/cert-manager/issues/6359), [@jetstack-bot](https://togithub.com/jetstack-bot)) ##### Other (Cleanup or Flake) - Updated base images to the latest version. ([#6372](https://togithub.com/cert-manager/cert-manager/issues/6372), [@inteon](https://togithub.com/inteon)) - Upgrade Go from 1.20.7 to 1.20.8. ([#6371](https://togithub.com/cert-manager/cert-manager/issues/6371), [@jetstack-bot](https://togithub.com/jetstack-bot)) ### [`v1.12.4`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.12.4) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.12.3...v1.12.4) v1.12.4 contains an important security fix that addresses [CVE-2023-29409](https://cve.report/CVE-2023-29409). #### Changes since v1.12.3 - Fixes an issue where cert-manager would incorrectly reject two IP addresses as being unequal when they should hav e compared equal. This would be most noticeable when using an IPv6 address which doesn't match how Go's `net.IP.String()` function would have printed that address. ([#6297](https://togithub.com/cert-manager/cert-manager/issues/6297), [@SgtCoDFish](https://togithub.com/SgtCoDFish)) - Use Go 1.20.7 to fix a security issue in Go's `crypto/tls` library. ([#6318](https://togithub.com/cert-manager/cert-manager/issues/6318), [@maelvls](https://togithub.com/maelvls)) </details> <details> <summary>truecharts/charts (clickhouse)</summary> ### [`v7.0.8`](https://togithub.com/truecharts/charts/releases/tag/clickhouse-7.0.8) [Compare Source](https://togithub.com/truecharts/charts/compare/clickhouse-7.0.7...clickhouse-7.0.8) ClickHouse is a column-oriented database management system (DBMS) for online analytical processing of queries (OLAP). ### [`v7.0.7`](https://togithub.com/truecharts/charts/releases/tag/clickhouse-7.0.7) [Compare Source](https://togithub.com/truecharts/charts/compare/clickhouse-7.0.6...clickhouse-7.0.7) ClickHouse is a column-oriented database management system (DBMS) for online analytical processing of queries (OLAP). ### [`v7.0.6`](https://togithub.com/truecharts/charts/releases/tag/clickhouse-7.0.6) [Compare Source](https://togithub.com/truecharts/charts/compare/clickhouse-7.0.5...clickhouse-7.0.6) ClickHouse is a column-oriented database management system (DBMS) for online analytical processing of queries (OLAP). ### [`v7.0.5`](https://togithub.com/truecharts/charts/releases/tag/clickhouse-7.0.5) [Compare Source](https://togithub.com/truecharts/charts/compare/clickhouse-7.0.4...clickhouse-7.0.5) ClickHouse is a column-oriented database management system (DBMS) for online analytical processing of queries (OLAP). ### [`v7.0.4`](https://togithub.com/truecharts/charts/releases/tag/clickhouse-7.0.4) [Compare Source](https://togithub.com/truecharts/charts/compare/clickhouse-7.0.3...clickhouse-7.0.4) ClickHouse is a column-oriented database management system (DBMS) for online analytical processing of queries (OLAP). ### [`v7.0.3`](https://togithub.com/truecharts/charts/releases/tag/clickhouse-7.0.3) [Compare Source](https://togithub.com/truecharts/charts/compare/clickhouse-7.0.2...clickhouse-7.0.3) ClickHouse is a column-oriented database management system (DBMS) for online analytical processing of queries (OLAP). ### [`v7.0.2`](https://togithub.com/truecharts/charts/releases/tag/clickhouse-7.0.2) [Compare Source](https://togithub.com/truecharts/charts/compare/clickhouse-7.0.1...clickhouse-7.0.2) ClickHouse is a column-oriented database management system (DBMS) for online analytical processing of queries (OLAP). </details> <details> <summary>truecharts/library-charts (common)</summary> ### [`v14.0.6`](https://togithub.com/truecharts/library-charts/releases/tag/common-14.0.6) [Compare Source](https://togithub.com/truecharts/library-charts/compare/common-14.0.5...common-14.0.6) Function library for TrueCharts ### [`v14.0.5`](https://togithub.com/truecharts/library-charts/releases/tag/common-14.0.5) [Compare Source](https://togithub.com/truecharts/library-charts/compare/common-14.0.4...common-14.0.5) Function library for TrueCharts ### [`v14.0.4`](https://togithub.com/truecharts/library-charts/releases/tag/common-14.0.4) [Compare Source](https://togithub.com/truecharts/library-charts/compare/common-14.0.3...common-14.0.4) Function library for TrueCharts ### [`v14.0.3`](https://togithub.com/truecharts/library-charts/releases/tag/common-14.0.3) [Compare Source](https://togithub.com/truecharts/library-charts/compare/common-14.0.2...common-14.0.3) Function library for TrueCharts ### [`v14.0.2`](https://togithub.com/truecharts/library-charts/releases/tag/common-14.0.2) [Compare Source](https://togithub.com/truecharts/library-charts/compare/common-14.0.1...common-14.0.2) Function library for TrueCharts </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on tuesday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cert-manager](https://togithub.com/cert-manager/cert-manager) | minor | `v1.12.3` -> `v1.13.1` | | [clickhouse](https://truecharts.org/charts/dependency/clickhouse) ([source](https://togithub.com/truecharts/charts)) | patch | `7.0.1` -> `7.0.9` | | [common](https://togithub.com/truecharts/apps/tree/master/charts/common) ([source](https://togithub.com/truecharts/library-charts)) | patch | `14.0.1` -> `14.0.9` | | [common](https://togithub.com/truecharts/apps/tree/master/charts/common) ([source](https://togithub.com/truecharts/library-charts)) | patch | `14.0.6` -> `14.0.9` | | [common](https://togithub.com/truecharts/apps/tree/master/charts/common) ([source](https://togithub.com/truecharts/library-charts)) | patch | `14.0.3` -> `14.0.9` | | [common](https://togithub.com/truecharts/apps/tree/master/charts/common) ([source](https://togithub.com/truecharts/library-charts)) | patch | `14.0.4` -> `14.0.9` | | [common](https://togithub.com/truecharts/apps/tree/master/charts/common) ([source](https://togithub.com/truecharts/library-charts)) | patch | `13.2.1` -> `13.2.2` | | [common](https://togithub.com/truecharts/apps/tree/master/charts/common) ([source](https://togithub.com/truecharts/library-charts)) | patch | `14.0.2` -> `14.0.9` | | [common](https://togithub.com/truecharts/apps/tree/master/charts/common) ([source](https://togithub.com/truecharts/library-charts)) | patch | `14.0.8` -> `14.0.9` | | [kube-state-metrics](https://truecharts.org/charts/dependency/kube-state-metrics) ([source](https://togithub.com/truecharts/charts)) | patch | `3.0.22` -> `3.0.23` | | [mariadb](https://truecharts.org/charts/dependency/mariadb) ([source](https://togithub.com/truecharts/charts)) | patch | `9.0.25` -> `9.0.26` | | [node-exporter](https://truecharts.org/charts/dependency/node-exporter) ([source](https://togithub.com/truecharts/charts)) | patch | `3.0.24` -> `3.0.25` | | [redis](https://truecharts.org/charts/dependency/redis) ([source](https://togithub.com/truecharts/charts)) | patch | `8.0.0` -> `8.0.29` | | [redis](https://truecharts.org/charts/dependency/redis) ([source](https://togithub.com/truecharts/charts)) | patch | `8.0.28` -> `8.0.29` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>cert-manager/cert-manager (cert-manager)</summary> ### [`v1.13.1`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.13.1) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.13.0...v1.13.1) v1.13.1 contains a bugfix for a name collision bug in the StableCertificateRequestName feature that was enabled by default in v1.13.0. ##### ⚠️ READ https://github.com/cert-manager/cert-manager/releases/tag/v1.13.0 before you upgrade from a < v1.13 version! #### Changes since v1.13.0 ##### Bug or Regression - BUGFIX: fix CertificateRequest name collision bug in StableCertificateRequestName feature. ([#6358](https://togithub.com/cert-manager/cert-manager/issues/6358), [@jetstack-bot](https://togithub.com/jetstack-bot)) ##### Other (Cleanup or Flake) - Upgrade `github.com/emicklei/go-restful/v3` to `v3.11.0` because `v3.10.2` is labeled as "DO NOT USE". ([#6368](https://togithub.com/cert-manager/cert-manager/issues/6368), [@inteon](https://togithub.com/inteon)) - Upgrade Go from 1.20.7 to 1.20.8. ([#6370](https://togithub.com/cert-manager/cert-manager/issues/6370), [@jetstack-bot](https://togithub.com/jetstack-bot)) ### [`v1.13.0`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.13.0) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.12.5...v1.13.0) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. This is the 1.13 release of cert-manager! cert-manager 1.13 brings support for DNS over HTTPS, support for loading options from a versioned config file for the cert-manager controller, and more. This release also includes the promotion of the StableCertificateRequestName and SecretsFilteredCaching feature gates to Beta. #### Known issues The `StableCertificateRequestName` that was promoted to Beta contains a "name collision" bug: [cert-manager/cert-manager#6342 This will be fixed in v1.13.1. #### Breaking Changes (You MUST read this before you upgrade!) 1. **BREAKING** : If you deploy cert-manager using helm and have `.featureGates` value set, the features defined there will no longer be passed to cert-manager webhook, only to cert-manager controller. Use `webhook.featureGates` field instead to define features to be enabled on webhook. ([#6093](https://togithub.com/cert-manager/cert-manager/issues/6093), [@irbekrm](https://togithub.com/irbekrm)) 2. **Potentially breaking**: If you were, for some reason, passing cert-manager controller's features to webhook's `--feature-gates` flag, this will now break (unless the webhook actually has a feature by that name). ([#6093](https://togithub.com/cert-manager/cert-manager/issues/6093), [@irbekrm](https://togithub.com/irbekrm)) 3. **Potentially breaking**: Webhook validation of CertificateRequest resources is stricter now: all KeyUsages and ExtendedKeyUsages must be defined directly in the CertificateRequest resource, the encoded CSR can never contain more usages that defined there. ([#6182](https://togithub.com/cert-manager/cert-manager/issues/6182), [@inteon](https://togithub.com/inteon)) #### Community Welcome to these new cert-manager members (more info - [cert-manager/cert-manager#6260): [@jsoref](https://togithub.com/jsoref) [@FlorianLiebhart](https://togithub.com/FlorianLiebhart) [@hawksight](https://togithub.com/hawksight) [@erikgb](https://togithub.com/erikgb) Thanks again to all open-source contributors with commits in this release, including: [@AcidLeroy](https://togithub.com/AcidLeroy) [@FlorianLiebhart](https://togithub.com/FlorianLiebhart) [@lucacome](https://togithub.com/lucacome) [@cypres](https://togithub.com/cypres) [@erikgb](https://togithub.com/erikgb) [@ubergesundheit](https://togithub.com/ubergesundheit) [@jkroepke](https://togithub.com/jkroepke) [@jsoref](https://togithub.com/jsoref) [@gdvalle](https://togithub.com/gdvalle) [@rouke-broersma](https://togithub.com/rouke-broersma) [@schrodit](https://togithub.com/schrodit) [@zhangzhiqiangcs](https://togithub.com/zhangzhiqiangcs) [@arukiidou](https://togithub.com/arukiidou) [@hawksight](https://togithub.com/hawksight) [@Richardds](https://togithub.com/Richardds) [@kahirokunn](https://togithub.com/kahirokunn) Thanks also to the following cert-manager maintainers for their contributions during this release: [@SgtCoDFish](https://togithub.com/SgtCoDFish) [@maelvls](https://togithub.com/maelvls) [@irbekrm](https://togithub.com/irbekrm) [@inteon](https://togithub.com/inteon) Equally thanks to everyone who provided feedback, helped users and raised issues on Github and Slack and joined our meetings! Special thanks to [@AcidLeroy](https://togithub.com/AcidLeroy) for adding "load options from a versioned config file" support for the cert-manager controller! This has been on our wishlist for a very long time. (see [cert-manager/cert-manager#5337) Also, thanks a lot to [@FlorianLiebhart](https://togithub.com/FlorianLiebhart) for adding support for DNS over HTTPS for the ACME DNS self-check. This is very useful in case all traffic must be HTTP(S) trafic, eg. when using a HTTPS_PROXY. (see [cert-manager/cert-manager#5003) Thanks also to the [CNCF](https://www.cncf.io/), which provides resources and support, and to the AWS open source team for being good community members and for their maintenance of the [PrivateCA Issuer](https://togithub.com/cert-manager/aws-privateca-issuer). In addition, massive thanks to [Venafi](https://www.venafi.com/) for contributing developer time and resources towards the continued maintenance of cert-manager projects. #### Changes since v1.12.0 ##### Feature - Add support for logging options to webhook config file. ([#6243](https://togithub.com/cert-manager/cert-manager/issues/6243), [@inteon](https://togithub.com/inteon)) - Add view permissions to the well-known (Openshift) user-facing `cluster-reader` aggregated cluster role ([#6241](https://togithub.com/cert-manager/cert-manager/issues/6241), [@erikgb](https://togithub.com/erikgb)) - Certificate Shim: distinguish dns names and ip address in certificate ([#6267](https://togithub.com/cert-manager/cert-manager/issues/6267), [@zhangzhiqiangcs](https://togithub.com/zhangzhiqiangcs)) - Cmctl can now be imported by third parties. ([#6049](https://togithub.com/cert-manager/cert-manager/issues/6049), [@SgtCoDFish](https://togithub.com/SgtCoDFish)) - Make `enableServiceLinks` configurable for all Deployments and `startupapicheck` Job in Helm chart. ([#6292](https://togithub.com/cert-manager/cert-manager/issues/6292), [@ubergesundheit](https://togithub.com/ubergesundheit)) - Promoted the StableCertificateRequestName and SecretsFilteredCaching feature gates to Beta (enabled by default). ([#6298](https://togithub.com/cert-manager/cert-manager/issues/6298), [@inteon](https://togithub.com/inteon)) - The cert-manager controller options are now configurable using a configuration file. ([#5337](https://togithub.com/cert-manager/cert-manager/issues/5337), [@AcidLeroy](https://togithub.com/AcidLeroy)) - The pki CertificateTemplate functions now perform validation of the CSR blob, making sure we sign a Certificate that matches the IsCA and (Extended)KeyUsages that are defined in the CertificateRequest resource. ([#6199](https://togithub.com/cert-manager/cert-manager/issues/6199), [@inteon](https://togithub.com/inteon)) - \[helm] Add prometheus.servicemonitor.endpointAdditionalProperties to define additional properties on a ServiceMonitor endpoint, e.g. relabelings ([#6110](https://togithub.com/cert-manager/cert-manager/issues/6110), [@jkroepke](https://togithub.com/jkroepke)) ##### Design - DNS over HTTPS (DoH) is now possible for doing the self-checks during the ACME verification. The DNS check method to be used is controlled through the command line flag: `--dns01-recursive-nameservers-only=true` in combination with `--dns01-recursive-nameservers=https://<DoH-endpoint>` (e.g. `https://8.8.8.8/dns-query`). It keeps using DNS lookup as a default method. ([#5003](https://togithub.com/cert-manager/cert-manager/issues/5003), [@FlorianLiebhart](https://togithub.com/FlorianLiebhart)) ##### Bug or Regression - Allow overriding default pdb .minAvailable with .maxUnavailable without setting .minAvailable to null ([#6087](https://togithub.com/cert-manager/cert-manager/issues/6087), [@rouke-broersma](https://togithub.com/rouke-broersma)) - BUGFIX: `cmctl check api --wait 0` exited without output and exit code 1; we now make sure we perform the API check at least once and return with the correct error code ([#6109](https://togithub.com/cert-manager/cert-manager/issues/6109), [@inteon](https://togithub.com/inteon)) - BUGFIX: the issuer and certificate-name annotations on a Secret were incorrectly updated when other fields are changed. ([#6147](https://togithub.com/cert-manager/cert-manager/issues/6147), [@inteon](https://togithub.com/inteon)) - BUGFIX\[cainjector]: 1-character bug was causing invalid log messages and a memory leak ([#6232](https://togithub.com/cert-manager/cert-manager/issues/6232), [@inteon](https://togithub.com/inteon)) - Fix CloudDNS issuers stuck in propagation check, when multiple instances are issuing for the same FQDN ([#6088](https://togithub.com/cert-manager/cert-manager/issues/6088), [@cypres](https://togithub.com/cypres)) - Fix indentation of Webhook NetworkPolicy matchLabels in helm chart. ([#6220](https://togithub.com/cert-manager/cert-manager/issues/6220), [@ubergesundheit](https://togithub.com/ubergesundheit)) - Fixed Cloudflare DNS01 challenge provider race condition when validating multiple domains ([#6191](https://togithub.com/cert-manager/cert-manager/issues/6191), [@Richardds](https://togithub.com/Richardds)) - Fixes a bug where webhook was pulling in controller's feature gates. **⚠️ ⚠️ BREAKING ⚠️ ⚠️** : If you deploy cert-manager using helm and have `.featureGates` value set, the features defined there will no longer be passed to cert-manager webhook, only to cert-manager controller. Use `webhook.featureGates` field instead to define features to be enabled on webhook. **⚠️Potentially breaking**: If you were, for some reason, passing cert-manager controller's features to webhook's `--feature-gates` flag, this will now break (unless the webhook actually has a feature by that name). ([#6093](https://togithub.com/cert-manager/cert-manager/issues/6093), [@irbekrm](https://togithub.com/irbekrm)) - Fixes an issue where cert-manager would incorrectly reject two IP addresses as being unequal when they should have compared equal. This would be most noticeable when using an IPv6 address which doesn't match how Go's `net.IP.String()` function would have printed that address. ([#6293](https://togithub.com/cert-manager/cert-manager/issues/6293), [@SgtCoDFish](https://togithub.com/SgtCoDFish)) - We disabled the `enableServiceLinks` option for our ACME http solver pods, because the option caused the pod to be in a crash loop in a cluster with lot of services. ([#6143](https://togithub.com/cert-manager/cert-manager/issues/6143), [@schrodit](https://togithub.com/schrodit)) - **⚠️Potentially breaking**: Webhook validation of CertificateRequest resources is stricter now: all KeyUsages and ExtendedKeyUsages must be defined directly in the CertificateRequest resource, the encoded CSR can never contain more usages that defined there. ([#6182](https://togithub.com/cert-manager/cert-manager/issues/6182), [@inteon](https://togithub.com/inteon)) ##### Other (Cleanup or Flake) - A subset of the klogs flags have been deprecated and will be removed in the future. ([#5879](https://togithub.com/cert-manager/cert-manager/issues/5879), [@maelvls](https://togithub.com/maelvls)) - All service links in helm chart deployments have been disabled. ([#6144](https://togithub.com/cert-manager/cert-manager/issues/6144), [@schrodit](https://togithub.com/schrodit)) - Cert-manager will now re-issue a certificate if the public key in the latest CertificateRequest resource linked to a Certificate resource does not match the public key of the key encoded in the Secret linked to that Certificate resource ([#6168](https://togithub.com/cert-manager/cert-manager/issues/6168), [@inteon](https://togithub.com/inteon)) - Chore: When hostNetwork is enabled, dnsPolicy is now set to ClusterFirstWithHostNet. ([#6156](https://togithub.com/cert-manager/cert-manager/issues/6156), [@kahirokunn](https://togithub.com/kahirokunn)) - Cleanup the controller configfile structure by introducing sub-structs. ([#6242](https://togithub.com/cert-manager/cert-manager/issues/6242), [@inteon](https://togithub.com/inteon)) - Don't run API Priority and Fairness controller in webhook's extension apiserver ([#6085](https://togithub.com/cert-manager/cert-manager/issues/6085), [@irbekrm](https://togithub.com/irbekrm)) - Helm: Add apache 2.0 license annotation ([#6225](https://togithub.com/cert-manager/cert-manager/issues/6225), [@arukiidou](https://togithub.com/arukiidou)) - Make apis/acme/v1/ACMEIssuer.PreferredChain optional in JSON serialization. ([#6034](https://togithub.com/cert-manager/cert-manager/issues/6034), [@gdvalle](https://togithub.com/gdvalle)) - The SecretPostIssuancePolicyChain now also makes sure that the `cert-manager.io/common-name`, `cert-manager.io/alt-names`, ... annotations on Secrets are kept at their correct value. ([#6176](https://togithub.com/cert-manager/cert-manager/issues/6176), [@inteon](https://togithub.com/inteon)) - The cmctl logging has been improved and support for json logging has been added. ([#6247](https://togithub.com/cert-manager/cert-manager/issues/6247), [@inteon](https://togithub.com/inteon)) - Updates Kubernetes libraries to `v0.27.2`. ([#6077](https://togithub.com/cert-manager/cert-manager/issues/6077), [@lucacome](https://togithub.com/lucacome)) - Updates Kubernetes libraries to `v0.27.4`. ([#6227](https://togithub.com/cert-manager/cert-manager/issues/6227), [@lucacome](https://togithub.com/lucacome)) - We now only check that the issuer name, kind and group annotations on a Secret match in case those annotations are set. ([#6152](https://togithub.com/cert-manager/cert-manager/issues/6152), [@inteon](https://togithub.com/inteon)) ### [`v1.12.5`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.12.5) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.12.4...v1.12.5) v1.12.5 contains a backport for a name collision bug that was found in v1.13.0 #### Changes since v1.12.4 ##### Bug or Regression - BUGFIX: fix CertificateRequest name collision bug in StableCertificateRequestName feature. ([#6359](https://togithub.com/cert-manager/cert-manager/issues/6359), [@jetstack-bot](https://togithub.com/jetstack-bot)) ##### Other (Cleanup or Flake) - Updated base images to the latest version. ([#6372](https://togithub.com/cert-manager/cert-manager/issues/6372), [@inteon](https://togithub.com/inteon)) - Upgrade Go from 1.20.7 to 1.20.8. ([#6371](https://togithub.com/cert-manager/cert-manager/issues/6371), [@jetstack-bot](https://togithub.com/jetstack-bot)) ### [`v1.12.4`](https://togithub.com/cert-manager/cert-manager/releases/tag/v1.12.4) [Compare Source](https://togithub.com/cert-manager/cert-manager/compare/v1.12.3...v1.12.4) v1.12.4 contains an important security fix that addresses [CVE-2023-29409](https://cve.report/CVE-2023-29409). #### Changes since v1.12.3 - Fixes an issue where cert-manager would incorrectly reject two IP addresses as being unequal when they should have compared equal. This would be most noticeable when using an IPv6 address which doesn't match how Go's `net.IP.String()` function would have printed that address. ([#6297](https://togithub.com/cert-manager/cert-manager/issues/6297), [@SgtCoDFish](https://togithub.com/SgtCoDFish)) - Use Go 1.20.7 to fix a security issue in Go's `crypto/tls` library. ([#6318](https://togithub.com/cert-manager/cert-manager/issues/6318), [@maelvls](https://togithub.com/maelvls)) </details> <details> <summary>truecharts/charts (clickhouse)</summary> ### [`v7.0.9`](https://togithub.com/truecharts/charts/releases/tag/clickhouse-7.0.9) [Compare Source](https://togithub.com/truecharts/charts/compare/clickhouse-7.0.8...clickhouse-7.0.9) ClickHouse is a column-oriented database management system (DBMS) for online analytical processing of queries (OLAP). ### [`v7.0.8`](https://togithub.com/truecharts/charts/releases/tag/clickhouse-7.0.8) [Compare Source](https://togithub.com/truecharts/charts/compare/clickhouse-7.0.7...clickhouse-7.0.8) ClickHouse is a column-oriented database management system (DBMS) for online analytical processing of queries (OLAP). ### [`v7.0.7`](https://togithub.com/truecharts/charts/releases/tag/clickhouse-7.0.7) [Compare Source](https://togithub.com/truecharts/charts/compare/clickhouse-7.0.6...clickhouse-7.0.7) ClickHouse is a column-oriented database management system (DBMS) for online analytical processing of queries (OLAP). ### [`v7.0.6`](https://togithub.com/truecharts/charts/releases/tag/clickhouse-7.0.6) [Compare Source](https://togithub.com/truecharts/charts/compare/clickhouse-7.0.5...clickhouse-7.0.6) ClickHouse is a column-oriented database management system (DBMS) for online analytical processing of queries (OLAP). ### [`v7.0.5`](https://togithub.com/truecharts/charts/releases/tag/clickhouse-7.0.5) [Compare Source](https://togithub.com/truecharts/charts/compare/clickhouse-7.0.4...clickhouse-7.0.5) ClickHouse is a column-oriented database management system (DBMS) for online analytical processing of queries (OLAP). ### [`v7.0.4`](https://togithub.com/truecharts/charts/releases/tag/clickhouse-7.0.4) [Compare Source](https://togithub.com/truecharts/charts/compare/clickhouse-7.0.3...clickhouse-7.0.4) ClickHouse is a column-oriented database management system (DBMS) for online analytical processing of queries (OLAP). ### [`v7.0.3`](https://togithub.com/truecharts/charts/releases/tag/clickhouse-7.0.3) [Compare Source](https://togithub.com/truecharts/charts/compare/clickhouse-7.0.2...clickhouse-7.0.3) ClickHouse is a column-oriented database management system (DBMS) for online analytical processing of queries (OLAP). ### [`v7.0.2`](https://togithub.com/truecharts/charts/releases/tag/clickhouse-7.0.2) [Compare Source](https://togithub.com/truecharts/charts/compare/clickhouse-7.0.1...clickhouse-7.0.2) ClickHouse is a column-oriented database management system (DBMS) for online analytical processing of queries (OLAP). </details> <details> <summary>truecharts/library-charts (common)</summary> ### [`v14.0.9`](https://togithub.com/truecharts/library-charts/releases/tag/common-14.0.9) [Compare Source](https://togithub.com/truecharts/library-charts/compare/common-14.0.8...common-14.0.9) Function library for TrueCharts ### [`v14.0.8`](https://togithub.com/truecharts/library-charts/releases/tag/common-14.0.8) [Compare Source](https://togithub.com/truecharts/library-charts/compare/common-14.0.7...common-14.0.8) Function library for TrueCharts ### [`v14.0.7`](https://togithub.com/truecharts/library-charts/releases/tag/common-14.0.7) [Compare Source](https://togithub.com/truecharts/library-charts/compare/common-14.0.6...common-14.0.7) Function library for TrueCharts ### [`v14.0.6`](https://togithub.com/truecharts/library-charts/releases/tag/common-14.0.6) [Compare Source](https://togithub.com/truecharts/library-charts/compare/common-14.0.5...common-14.0.6) Function library for TrueCharts ### [`v14.0.5`](https://togithub.com/truecharts/library-charts/releases/tag/common-14.0.5) [Compare Source](https://togithub.com/truecharts/library-charts/compare/common-14.0.4...common-14.0.5) Function library for TrueCharts ### [`v14.0.4`](https://togithub.com/truecharts/library-charts/releases/tag/common-14.0.4) [Compare Source](https://togithub.com/truecharts/library-charts/compare/common-14.0.3...common-14.0.4) Function library for TrueCharts ### [`v14.0.3`](https://togithub.com/truecharts/library-charts/releases/tag/common-14.0.3) [Compare Source](https://togithub.com/truecharts/library-charts/compare/common-14.0.2...common-14.0.3) Function library for TrueCharts ### [`v14.0.2`](https://togithub.com/truecharts/library-charts/releases/tag/common-14.0.2) [Compare Source](https://togithub.com/truecharts/library-charts/compare/common-14.0.1...common-14.0.2) Function library for TrueCharts </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on tuesday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  --------- Signed-off-by: TrueCharts-Bot <bot@truecharts.org> Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com> Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>

jetstack-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 30, 2022

FlorianLiebhart force-pushed the DNS-over-https-check branch from 00baf63 to b71ad7e Compare March 30, 2022 09:49

jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Mar 30, 2022

FlorianLiebhart force-pushed the DNS-over-https-check branch from b71ad7e to 5ae3154 Compare March 30, 2022 09:55

jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 4, 2022

jetstack-bot added the area/testing Issues relating to testing label Apr 4, 2022

jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Apr 4, 2022

FlorianLiebhart force-pushed the DNS-over-https-check branch from 7c817f1 to 53c2177 Compare April 4, 2022 22:56

jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Apr 4, 2022

SgtCoDFish mentioned this pull request Apr 28, 2022

Support DoT (DNS over TLS) for Recursive Nameservers #4153

Closed

maelvls mentioned this pull request May 2, 2022

Excessive DNS caching for DNS verification #3743

Closed

update doku on flags

9ef3edc

Signed-off-by: Florian Liebhart <flo.liebhart@gmail.com>

maelvls reviewed Jun 20, 2023

View reviewed changes

cmd/controller/app/options/options.go Outdated Show resolved Hide resolved

FlorianLiebhart added 3 commits June 20, 2023 16:38

reorganize import

876c39b

Signed-off-by: Florian Liebhart <flo.liebhart@gmail.com>

add newline

601c06c

Signed-off-by: Florian Liebhart <flo.liebhart@gmail.com>

update code comment on the recursive nameserver flag

b6dbee6

Signed-off-by: Florian Liebhart <flo.liebhart@gmail.com>

jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 20, 2023

jetstack-bot assigned maelvls Jun 20, 2023

jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023

jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2023

jetstack-bot merged commit 716bd30 into cert-manager:master Jun 20, 2023
6 checks passed

maelvls mentioned this pull request Jul 31, 2023

Write documentation for the new DNS-over-HTTPS feature #6246

Open

FlorianLiebhart mentioned this pull request Sep 7, 2023

REQUEST: New membership for FlorianLiebhart cert-manager/community#8

Closed

7 tasks

p-linnane mentioned this pull request Sep 13, 2023

cmctl 1.13.0 Homebrew/homebrew-core#142149

Merged

linhng98 mentioned this pull request Feb 21, 2024

chore(deps): update all non-major dependencies linhng98/mess-around#84

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement the DNS-over-HTTPS check #5003

Implement the DNS-over-HTTPS check #5003

FlorianLiebhart commented Mar 30, 2022 •

edited

jetstack-bot commented Mar 30, 2022

jakexks commented Apr 4, 2022

FlorianLiebhart commented Apr 4, 2022

FlorianLiebhart commented Apr 4, 2022

FlorianLiebhart commented Apr 4, 2022

FlorianLiebhart commented Apr 4, 2022

FlorianLiebhart commented Apr 4, 2022

FlorianLiebhart commented Apr 5, 2022

jetstack-bot commented Jun 20, 2023 •

edited

maelvls commented Jun 20, 2023

maelvls commented Jun 20, 2023

maelvls commented Jun 20, 2023

FlorianLiebhart commented Jun 20, 2023

hvpareja commented Jun 20, 2023

muffl0n commented Jun 21, 2023 •

edited

inteon commented Jun 21, 2023

muffl0n commented Jun 21, 2023

FlorianLiebhart commented Jun 21, 2023 •

edited

Implement the DNS-over-HTTPS check #5003

Implement the DNS-over-HTTPS check #5003

Conversation

FlorianLiebhart commented Mar 30, 2022 • edited

Pull Request Motivation

Kind

Release Note

jetstack-bot commented Mar 30, 2022

jakexks commented Apr 4, 2022

FlorianLiebhart commented Apr 4, 2022

FlorianLiebhart commented Apr 4, 2022

FlorianLiebhart commented Apr 4, 2022

FlorianLiebhart commented Apr 4, 2022

FlorianLiebhart commented Apr 4, 2022

FlorianLiebhart commented Apr 5, 2022

jetstack-bot commented Jun 20, 2023 • edited

maelvls commented Jun 20, 2023

maelvls commented Jun 20, 2023

maelvls commented Jun 20, 2023

FlorianLiebhart commented Jun 20, 2023

hvpareja commented Jun 20, 2023

muffl0n commented Jun 21, 2023 • edited

inteon commented Jun 21, 2023

muffl0n commented Jun 21, 2023

FlorianLiebhart commented Jun 21, 2023 • edited

FlorianLiebhart commented Mar 30, 2022 •

edited

jetstack-bot commented Jun 20, 2023 •

edited

muffl0n commented Jun 21, 2023 •

edited

FlorianLiebhart commented Jun 21, 2023 •

edited