Fix the default "third_party" folder exclusion#294
Merged
cert-manager-prow[bot] merged 1 commit intoJun 3, 2025
Conversation
cert-manager-prow
Bot
added
dco-signoff: yes
So that it includes sub-folders too. Signed-off-by: Richard Wall <richard.wall@cyberark.com>
wallrj
force-pushed
the
fix-third_party_exclusion
branch
from
5466c1a to
7d2d07a
Compare
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cert-manager we've added a
third_party/forked/folder, which contains code that does not pass all the default linter checks which are added by this module.I went to the
.golangci-lint.yamlfile expecting to be able to exclude that folder and found that there was already an exclusion,but it wasn't working because of the trailing
$.I tried to add an unadorned
third_partyexclusion, but that got overwritten by themake generate-golangci-linttarget.So I've created this PR as a work around.
Here's an example of it working:
Ideally I'd want to specify custom exclusions. Here's a follow up issue for that:
make generate-golangci-lint-configclobbers local exclusions added to the local config. #295