Make CRD condition expression configurable

[inteon]

For the cert-manager/cert-manager repo, we want the expression to be or .Values.crds.enabled .Values.installCRDs instead of just .Values.crds.enabled.

See cert-manager/cert-manager#7718 for the full PR.

[erikgb]

/lgtm
/approve
/hold

Could we deprecated the "non-standard" value for this in cert-manager and avoid this change? I am guessing there was a reason for renaming this value in newer projects (compared to cert-manager).

[cert-manager-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [erikgb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[inteon]

/lgtm /approve /hold

Could we deprecated the "non-standard" value for this in cert-manager and avoid this change? I am guessing there was a reason for renaming this value in newer projects (compared to cert-manager).

We already show a deprecation warning: https://github.com/cert-manager/cert-manager/blob/99aded1d141f6c5fd11399f2a1054c50b6f09fcd/deploy/charts/cert-manager/templates/NOTES.txt#L2
It will probably take a while before we fully remove the option.
I think we used crds.enabled in the other projects and cert-manager/cert-manager was the only project that did not use it yet.

/unhold