New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds section in usage/certificates for additional output formats #797
Adds section in usage/certificates for additional output formats #797
Conversation
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: 29757de 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61e6a583c89e8e0007947f6d 😎 Browse the preview: https://deploy-preview-797--cert-manager-website.netlify.app/docs/usage/certificate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few comments but they're pretty minor, I like this addition and I think this'll be a great improvement 👍
Thanks for the review @SgtCoDFish, please take another look and let me know if you would like any more changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Good stuff 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoshVanL, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
/lgtm |
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
Signed-off-by: joshvanl vleeuwenjoshua@gmail.com
Adds a section to Usage/Certificates for the Additional Output Formats feature.
See: cert-manager/cert-manager#4598