Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds section in usage/certificates for additional output formats #797

Conversation

JoshVanL
Copy link
Collaborator

Signed-off-by: joshvanl vleeuwenjoshua@gmail.com

Adds a section to Usage/Certificates for the Additional Output Formats feature.

See: cert-manager/cert-manager#4598

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 17, 2022
@netlify
Copy link

netlify bot commented Jan 17, 2022

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 29757de

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/61e6a583c89e8e0007947f6d

😎 Browse the preview: https://deploy-preview-797--cert-manager-website.netlify.app/docs/usage/certificate

Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments but they're pretty minor, I like this addition and I think this'll be a great improvement 👍

content/en/docs/usage/certificate.md Outdated Show resolved Hide resolved
content/en/docs/usage/certificate.md Show resolved Hide resolved
content/en/docs/usage/certificate.md Outdated Show resolved Hide resolved
@SgtCoDFish SgtCoDFish changed the title Adds secretion in usege/certificates for additional output formats Adds section in usage/certificates for additional output formats Jan 18, 2022
@JoshVanL
Copy link
Collaborator Author

Thanks for the review @SgtCoDFish, please take another look and let me know if you would like any more changes

Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Good stuff 👍

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JoshVanL,SgtCoDFish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@SgtCoDFish SgtCoDFish added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 18, 2022
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
@SgtCoDFish
Copy link
Member

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot merged commit 76fea1e into cert-manager:release-next Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants