Certbot opens curses sessions for informational notices, breaking automation #3764

Closed
starchy opened this Issue Nov 7, 2016 · 4 comments

Comments

Projects
None yet
2 participants

starchy commented Nov 7, 2016

This was spotted on older clients still using the letsencrypt-auto command line. Our cron jobs:
/opt/letsencrypt/letsencrypt-auto certonly --config /etc/letsencrypt/cli.ini --agree-tos --renew-by-default --expand
failed with:
An unexpected error occurred:
Bug in pythondialog: expected an empty output from u'infobox', but got: u'Error opening terminal: unknown.\n'Please see the logfile 'certbot.log' for more details.

Running interactively shows the client opening a curses dialog (where previous versions did not), although there were only an information notices displayed:


| Saving debug log to /var/log/letsencrypt/letsencrypt.log │
│ Starting new HTTPS connection (1): acme-v01.api.letsencrypt.org │
│ Renewing an existing certificate │
│ Performing the following challenges: │
│ http-01 challenge for irc.eff.org │
│ Using the webroot path /var/www/letsencrypt for all unmatched │
│ domains. │
│ Waiting for verification... │
│ Cleaning up challenges │
│ Generating key (2048 bits): │
│ /etc/letsencrypt/keys/0004_key-certbot.pem │
│ Creating CSR: /etc/letsencrypt/csr/0004_csr-certbot.pem |

Adding the --non-interactive switch resolves the issue, but this is a breaking change for many existing pre-certbot cronjobs.

Owner

pde commented Nov 7, 2016

Ahhh, I think this is already fixed (by drastic means, removing the dialog-based user interface) in git master and the forthcoming 0.10.0 release.

Owner

pde commented Nov 7, 2016

Could you confirm that by trying to run the current git master tree (https://certbot.eff.org/docs/contributing.html#running-a-local-copy-of-the-client) with the same flags and seeing if it works?

Owner

pde commented Nov 7, 2016

BTW, you should definitely deprecate that commandline; --renew-by-default aka --force-renewal should no longer be necessary for a good renewal script.

@pde pde added this to the 0.10.0 milestone Nov 7, 2016

Owner

pde commented Nov 7, 2016

Closing this, but please reopen if you can reproduce with the current git master tree.

@pde pde closed this Nov 7, 2016

@pde pde removed the has pr label Dec 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment