Switch from nose to pytest #5282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
reviewed
Nov 30, 2017
| @@ -6,13 +6,15 @@ FROM debian:wheezy | |||
| # Add an unprivileged user: | |||
| RUN useradd --create-home --home-dir /home/lea --shell /bin/bash --groups sudo --uid 1000 lea | |||
|
|
|||
| # Install pip, sudo, openssl, and nose: | |||
| # Install pip, sudo, openssl, and pytest: | |||
There was a problem hiding this comment.
The lines immediately below this don't install pytest, so just remove pytest from this line. Same edit for anything starting with "Install pip, " in this change.
There was a problem hiding this comment.
I made the pytest changes.
I think the "Install pip" comments are accurate as we do install pip from the package manager, but then update it through pipstrap so I changed comments to clarify this.
jsha
approved these changes
Dec 1, 2017
This was referenced Dec 1, 2017
Merged
tobypeterson
added a commit
to macports/macports-ports
that referenced
this pull request
Oct 28, 2020
Schamschula
added a commit
to Schamschula/macports
that referenced
this pull request
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4377 and #4825.
noseis no longer maintained so let's switch to a framework that is.A couple things to note here:
_multiprocess_can_split_lines were fornose's multiprocessing plugin as documented here and have been removed.noseimproperly reporting the coverage percentage andpytestreporting coverage to the nearest hundreth of a percent rather than the nearest whole percentage point.route53was particularly affected becausenosewasn't reporting coverage on an entire file.