Remove tls-sni-01 challenges in integration tests #6679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adferrand
force-pushed
the
remove-tls-sni-integration-tests
branch
2 times, most recently
from
62ba30d
to
35d6af8
Compare
adferrand
force-pushed
the
remove-tls-sni-integration-tests
branch
from
35d6af8
to
be6e427
Compare
adferrand
force-pushed
the
remove-tls-sni-integration-tests
branch
from
be6e427
to
a69066a
Compare
joohoi
suggested changes
Jan 20, 2019
joohoi
approved these changes
Jan 20, 2019
bmw
pushed a commit
that referenced
this pull request
Jan 30, 2019
) This PR reactivates tls-sni-01 challenges on recent Boulder versions checkout for integration tests. This allows to continue testing this challenge until it is officially dropped from server (Boulder) and client (Certbot). Reverts #6679.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since letsencrypt/boulder@92e8e17, Boulder does not propose anymore tls-sni-01 challenges. This makes fail the Certbot integration tests that require to fulfill a tls-sni-01 challenge.
This PR removes all operations relevant to this deprecated and soon extincted challenge.