New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Devuan instructions #267

Merged
merged 4 commits into from Jul 17, 2017

Conversation

Projects
None yet
3 participants
@bmw
Contributor

bmw commented Jul 7, 2017

Add instructions for Devuan based on the conversation in certbot/certbot#4903.

@bmw bmw requested a review from SwartzCr Jul 7, 2017

@bmw bmw referenced this pull request Jul 7, 2017

Closed

First Devuan integration #4903

@maurorappa

This comment has been minimized.

Show comment
Hide comment
@maurorappa

maurorappa Jul 17, 2017

Hi, any ETA on this? :)

maurorappa commented Jul 17, 2017

Hi, any ETA on this? :)

@@ -95,6 +97,7 @@ module.exports = function(context) {
debian_install = function() {
template = "debian";
context.devuan = context.distro == "devuan"

This comment has been minimized.

@SwartzCr

SwartzCr Jul 17, 2017

Contributor

Won't this make every debian install devuan? Since it's in the body of the debian_install function the context.devuan flag will be truethy meaning that everyone will get the devuan backports instructions

@SwartzCr

SwartzCr Jul 17, 2017

Contributor

Won't this make every debian install devuan? Since it's in the body of the debian_install function the context.devuan flag will be truethy meaning that everyone will get the devuan backports instructions

This comment has been minimized.

@bmw

bmw Jul 17, 2017

Contributor

context.devuan is set to true only if context.distro is "devuan"`. If it is, we'll use the Devuan instructions, otherwise, we'll use the Debian instructions.

I've tested this works properly using the built website.

@bmw

bmw Jul 17, 2017

Contributor

context.devuan is set to true only if context.distro is "devuan"`. If it is, we'll use the Devuan instructions, otherwise, we'll use the Debian instructions.

I've tested this works properly using the built website.

// Debian Jessie backports.
if (context.version == 8) {
// Jessie backports.
if ((context.devuan && context.version == 1) || context.version == 8) {

This comment has been minimized.

@SwartzCr

SwartzCr Jul 17, 2017

Contributor

Is it true that on devuan 0 you'll not need to enable backports, but will be able to use apt to install it?

@SwartzCr

SwartzCr Jul 17, 2017

Contributor

Is it true that on devuan 0 you'll not need to enable backports, but will be able to use apt to install it?

This comment has been minimized.

@bmw

bmw Jul 17, 2017

Contributor

Yes. Devuan is very similar to Debian. If you have Devuan testing or unstable, it's available in the official repos.

@bmw

bmw Jul 17, 2017

Contributor

Yes. Devuan is very similar to Debian. If you have Devuan testing or unstable, it's available in the official repos.

@SwartzCr

This comment has been minimized.

Show comment
Hide comment
@SwartzCr

SwartzCr Jul 17, 2017

Contributor

Sorry for the extreme delay!
Just left some comments for brad - hope to get this merged soon

Contributor

SwartzCr commented Jul 17, 2017

Sorry for the extreme delay!
Just left some comments for brad - hope to get this merged soon

@SwartzCr

This comment has been minimized.

Show comment
Hide comment
@SwartzCr

SwartzCr Jul 17, 2017

Contributor

okay - lgtm, merging!

Contributor

SwartzCr commented Jul 17, 2017

okay - lgtm, merging!

@SwartzCr SwartzCr merged commit f197056 into master Jul 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bmw bmw deleted the devuan branch Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment