Added Email Alert Functionality - #129
Conversation
|
Looks good to me. Tommorrow We are going to fix the github action linter bug (it is on our side, I've already checked) and merge the PR |
|
Hi @kunalsz, can you run linters and formatters as documented here? https://github.com/certego/BuffaLogs/blob/main/CONTRIBUTING.md |
|
@ManofWax sure, I'll do that and update you. |
|
Hi @ManofWax , there were some problems in linting on my side. I have fixed them and linted code. Please review it. |
|
@Lorygold I will align my code with the updates soon. |
Signed-off-by: kunalsz <kunalavengers@gmail.com>
|
Hi @kunalsz, there's an error in your test: Before committing, you can run tests locally launching |
|
@Lorygold I have fixed that error but I am facing this error which is not originating from my code This can be fixed by updating this code in Should I proceed with that ? |
Signed-off-by: kunalsz <kunalavengers@gmail.com>
It's an error that is present only in your workspace, so probably I think that you didn't load the template on Elasticsearch, running: Please, commit again to: |
I had already implemented the email alerting functionality but given the new Alert classes ,I have reimplemented it.
In reference to the issue #126
Changes made
impossible_travel/alertingis createdemail_alerting.pyto send the emails to a specific address using Django'ssend_emailfunctionalityOutcomes
@patchfunctionality implemented in thetests/test_alert_email.py. Will work on this.placeholders are left in the place of actual email addresses and app password
Looking forward for your insights and advices !
@ManofWax