Skip to content

Added Pushover Alerter Functionality - #141

Merged
ManofWax merged 1 commit into
certego:developfrom
kunalsz:alert_pushover
Mar 12, 2025
Merged

ManofWax merged 1 commit into
certego:developfrom
kunalsz:alert_pushover

Conversation

@kunalsz

@kunalsz kunalsz commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

In reference to the issue #135
For full documentation on how to implement and use it refer to docs/alerting/pushover.md

Changes made

  • New Pushover alerting module implemented using requests
  • Users can receive alerts on their Pushover Client(Mobile/Web)

Outcomes

  • All tests are getting passed.
  • Alerts being received on the pushover client

@ManofWax looking forward to your insights !

@kunalsz

kunalsz commented Feb 28, 2025 •

Copy link
Copy Markdown
Contributor Author

@ManofWax I am sorry working on the issues already discussed about. I started working on them earlier without commenting under the issue in due time.

@Lorygold Lorygold linked an issue Feb 28, 2025 that may be closed by this pull request
@Lorygold

Copy link
Copy Markdown
Contributor

Please @kunalsz change the target branch of the PR from main to develop

@kunalsz
kunalsz changed the base branch from main to develop February 28, 2025 17:06
@Lorygold

Lorygold commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

Hi @kunalsz , linters have been fixed in the PR #146. So, please align your feature branch with the develop one and resolve the conflicts with your code

@ManofWax ManofWax linked an issue Mar 3, 2025 that may be closed by this pull request
@kunalsz

kunalsz commented Mar 4, 2025

Copy link
Copy Markdown
Contributor Author

@Lorygold I will fix that soon.

Comment thread buffalogs/impossible_travel/tests/test_alert_pushover.py Outdated
Signed-off-by: kunalsz <kunalavengers@gmail.com>
@kunalsz
kunalsz requested a review from ManofWax March 9, 2025 12:49
@kunalsz

kunalsz commented Mar 12, 2025

Copy link
Copy Markdown
Contributor Author

@Lorygold @ManofWax I have made the necessary changes, you can now merge it

@ManofWax
ManofWax merged commit afd27fc into certego:develop Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alerter: add Pushover alerter

3 participants