Refactored Hardcoded Paths - #196
Merged
Merged
Conversation
Signed-off-by: kunalsz <kunalavengers@gmail.com>
Lorygold
self-requested a review
March 24, 2025 08:18
Lorygold
reviewed
Mar 24, 2025
Lorygold
left a comment
Lorygold
left a comment
Contributor
There was a problem hiding this comment.
Hi @kunalsz, maybe we can reduce the memory allocation removing the DATA_PATH definition? For example inserting the path directly in the open function, such as:
with open(os.path.join(settings.CERTEGO_DJANGO_PROJ_BASE_DIR, "impossible_travel/dashboard/", name + ".json"), encoding="utf-8") as file:
data = json.load(file)
I think it works, but it has to be tested
Contributor
Author
|
@Lorygold Yes this will be more efficient, I will refactor the code. |
Signed-off-by: kunalsz <kunalavengers@gmail.com>
Lorygold
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reference to the issue #193
All the tests are getting passed normally.
@Lorygold I have made the necessary changes, and yes you were right it was
settings.CERTEGO_DJANGO_PROJ_BASE_DIRnotsettings.BASE_DIR.