Alert Preferences System

[kunalsz]

Resolves #321

Changes Made:

• active_alerter changed to active_alerters
• Users can provide multiple alerters as a list inside the config to receive alerts on multiple sources at once

[kunalsz]

Hi @ManofWax @Lorygold ,how can I write a test to see if alerts are actually being notified on multiple sources simultaneously when a alert is generated?

[ManofWax]

I think you should mock the various alerts objects you want to call and check if the mock function is being actually called.

[kunalsz]

@ManofWax I have added tests, they work fine. But during testing I noticed that when an alert is notified through an alerter , the alert is marked notified=True . So to send an alert through multiple alerters simultaneously we have to mark it notified=False.
For this I also updated the code in tasks.py, is this the correct approach ? Looking forward to your suggestions.

[Lorygold]

I think that, at this point, the Alert.notified field could become a JSON field that keeps track of each active_alerter status:

Alert.notified_status = models.JSONField(default=dict, blank=True, help_text="Tracks each active_alerter status")  # example: {"email": True, "slack": False}

In this way, each alerter can set True if its forward ended correctly, False otherwise.
Then, this approach may also be useful for future development related to the alerting retry mechanism.

Let's waiting for the @ManofWax's feedback, too.

[ManofWax]

Yeah I think the JSON field is a good solution

[kunalsz]

@ManofWax @Lorygold I have updated the notified field with notified_status.