Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Timeouts in goals? #13

Closed
anttipoi opened this Issue Apr 13, 2012 · 5 comments

Comments

Projects
None yet
2 participants

I'm having occasional build failures on a criminally slow build server of mine. It seems the goals set up timeouts, like:

ExecuteWatchdog watchdog = new ExecuteWatchdog(120000); // 2min, even for Scala should be ok

What is the rationale for adding the timeouts? Is there a chance for play commands to hang?

These timeouts seem troublesome to me and if there's no good reason for them I'd suggest removing them.

Owner

cescoffier commented Apr 13, 2012

Hi,

What about being able to configure them ? Something like:

<timeout>time in milli</timeout>

Default to 2 min, but passing -1 or 0 just disable it.

Acceptable. Yet I wonder what is the issue that makes these timeouts necessary?

T. Teemu

On 13.4.2012, at 13.46, Clement Escoffier reply@reply.github.com wrote:

Hi,

What about being able to configure them ? Something like:

time in milli

Default to 2 min, but passing -1 or 0 just disable it.


Reply to this email directly or view it on GitHub:
#13 (comment)

Owner

cescoffier commented Apr 13, 2012

Hi,

I've slightly changed my mind:

  • the timeout setting is disabled by default, meaning that the plugin waits until the completion of the play2 command
  • if set, then the timeout is applied and the watchdog is configured.

Why do I have this timeout ? It's just because we have test relying on a pretty picky server which sometimes hang. In that case it's important that the tests fail. But with this new setting, everything will be ok.

cescoffier added a commit that referenced this issue Apr 13, 2012

#13 - Timeout in Goals ?
Added a timeout setting allowing to enable the watchdog on play 2 processes. If not set, the plugin just waits until process completion.

@ghost ghost assigned cescoffier Apr 13, 2012

Owner

cescoffier commented Apr 13, 2012

Fixed in master.

@cescoffier cescoffier closed this Apr 13, 2012

Great! Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment