Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cache-control #6

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

add cache-control #6

wants to merge 1 commit into from

Conversation

cesine
Copy link
Owner

@cesine cesine commented Nov 24, 2022

to show its not working

how to test:

$ curl -Ik http://sapin.localhost:3000/
HTTP/1.1 200 OK
Cache-Control: no-store, must-revalidate
X-Powered-By: Next.js
Content-Type: text/html; charset=utf-8
Vary: Accept-Encoding
Date: Thu, 24 Nov 2022 21:27:17 GMT
Connection: keep-alive
Keep-Alive: timeout=5

@cesine
add cache-control
5a298ad 
to show its not working
@vercel
Copy link

vercel bot commented Nov 24, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextjs-tdd-interview-base ❌ Failed (Inspect) Nov 24, 2022 at 9:28PM (UTC)

cesine
cesine commented Nov 24, 2022
View reviewed changes
pages/_sites/sapin/index.tsx
@@ -62,7 +62,7 @@ export async function getServerSideProps({ req }: { req: NextApiRequest }) {
}
products = [e.status];
}

res.setHeader('Cache-Control', 'max-age=900');
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is following the docs https://nextjs.org/docs/going-to-production#caching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cesine