Centralize Makefile logic in baselayer #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice! |
stefanv
reviewed
Oct 24, 2017
Makefile
Outdated
| status: | ||
| PYTHONPATH='.' ./baselayer/tools/supervisor_status.py | ||
| test: | ||
| make -C baselayer paths dependencies |
Contributor
There was a problem hiding this comment.
I guess this could just as well become
test:
make -C baselayer test
stefanv
reviewed
Oct 24, 2017
test_config.yaml
Outdated
| port: 5432 | ||
|
|
||
| server: | ||
| url: http://localhost:5000 |
Contributor
There was a problem hiding this comment.
Neat, we can now run tests on a different port, so that it doesn't conflict with any existing running version!
stefanv
approved these changes
Oct 24, 2017
bnaul
force-pushed
the
master
branch
3 times, most recently
from
b4d3961 to
fcb21b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.